Skip to content

Bump serialize-javascript to 7.0.5 (CVE-2026-34043) #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robandpdx merged 2 commits into from
Apr 6, 2026
Merged

Bump serialize-javascript to 7.0.5 (CVE-2026-34043) #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000a160
Initial plan
Copilot Apr 2, 2026
5edbfad
Fix CVE-2026-34043: upgrade serialize-javascript to 7.0.5 via npm ove…
Copilot Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 5 additions & 30 deletions .github/scripts/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .github/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
"branches": [
"main"
]
},
"overrides": {
"serialize-javascript": "7.0.5"
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrides is forcing serialize-javascript to 7.0.5 globally even though the only known consumer here (mocha) declares serialize-javascript: ^6.0.2 in the lockfile. Because this is a semver-major jump for a transitive dependency, consider scoping the override to just mocha (npm supports nested overrides) to reduce blast radius and make the intent clearer.

Suggested change
"serialize-javascript": "7.0.5"
"mocha": {
"serialize-javascript": "7.0.5"
}

Copilot uses AI. Check for mistakes.
}
}
Loading