TypeScript SDK API review fixes#1357

Merged

SteveSandersonMS merged 27 commits into

mainfrom

stevesandersonms/typescript-api-review-fixes

May 21, 2026

Commits on May 21, 2026

Phase A: property/method renames on SessionConfig/ResumeSessionConfig

SteveSandersonMS
and
Copilot
committed
Phase C: CopilotClientOptions / MCP / streaming shape changes

SteveSandersonMS
and
Copilot
committed
Phase D: lifecycle event polymorphic union + Date timestamps

SteveSandersonMS
and
Copilot
committed
Phase E: hook input timestamps as Date

SteveSandersonMS
and
Copilot
committed
Phase F: PermissionRequestResult.feedback + use generated PermissionRequest union

SteveSandersonMS
and
Copilot
committed
Phase G: extract SessionConfigBase

SteveSandersonMS
and
Copilot
committed
Phase H: defineTool({ name, ... }) single-arg form

SteveSandersonMS
and
Copilot
committed
Revert "Phase H: defineTool({ name, ... }) single-arg form"
SteveSandersonMS
committed
Phase I: RuntimeConnection discriminated config

SteveSandersonMS
and
Copilot
committed
Phase J: send / sendAndWait string overloads

SteveSandersonMS
and
Copilot
committed
Phase K: stripInternal, AsyncDisposable, clean stop(), drop destroy()

SteveSandersonMS
and
Copilot
committed
Phase L: fix githubToken typos in scenario fixtures

SteveSandersonMS
and
Copilot
committed
Phase L follow-up: run prettier --write over all modified files

SteveSandersonMS
and
Copilot
committed
Fix Phase I/E/L test failures surfaced by CI

SteveSandersonMS
and
Copilot
committed
Add E2E equivalents of removed createSession/resumeSession-without-permission tests

SteveSandersonMS
and
Copilot
committed
Add E2E tests for createSession/resumeSession without onPermissionRequest

SteveSandersonMS
and
Copilot
committed
Harness: preserve caller-supplied RuntimeConnection while still injecting CLI path

SteveSandersonMS
and
Copilot
committed
session_fs.e2e: fix unconverted tcpConnectionToken flat key on inner client

SteveSandersonMS
and
Copilot
committed
Move hook input deserialization next to the cast that types it

SteveSandersonMS
and
Copilot
committed
Phase K refinement: use unref() instead of destroy() in client.stop()

SteveSandersonMS
and
Copilot
committed
client.stop(): await child exit and socket close

SteveSandersonMS
and
Copilot
committed
Revert incorrect feedback widening of PermissionRequestResult

SteveSandersonMS
and
Copilot
committed
Rename client.on -> client.onLifecycle for cross-SDK consistency

SteveSandersonMS
and
Copilot
committed
Reformat src/types.ts after PermissionRequestResult revert

SteveSandersonMS
and
Copilot
committed
Address PR review comments from #1357

SteveSandersonMS
and
Copilot
committed
logLevel: don't impose any default, match C#/Go

SteveSandersonMS
and
Copilot
committed
Rename CopilotClientOptions.remote -> enableRemoteSessions for cross-SDK consistency

SteveSandersonMS
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeScript SDK API review fixes#1357

TypeScript SDK API review fixes#1357
SteveSandersonMS merged 27 commits into
mainfrom
stevesandersonms/typescript-api-review-fixes

Commits on May 21, 2026

Phase A: property/method renames on SessionConfig/ResumeSessionConfig

Phase C: CopilotClientOptions / MCP / streaming shape changes

Phase D: lifecycle event polymorphic union + Date timestamps

Phase E: hook input timestamps as Date

Phase F: PermissionRequestResult.feedback + use generated PermissionRequest union

Phase G: extract SessionConfigBase

Phase H: defineTool({ name, ... }) single-arg form

Revert "Phase H: defineTool({ name, ... }) single-arg form"

Phase I: RuntimeConnection discriminated config

Phase J: send / sendAndWait string overloads

Phase K: stripInternal, AsyncDisposable, clean stop(), drop destroy()

Phase L: fix githubToken typos in scenario fixtures

Phase L follow-up: run prettier --write over all modified files

Fix Phase I/E/L test failures surfaced by CI

Add E2E equivalents of removed createSession/resumeSession-without-permission tests

Add E2E tests for createSession/resumeSession without onPermissionRequest

Harness: preserve caller-supplied RuntimeConnection while still injecting CLI path

session_fs.e2e: fix unconverted tcpConnectionToken flat key on inner client

Move hook input deserialization next to the cast that types it

Phase K refinement: use unref() instead of destroy() in client.stop()

client.stop(): await child exit and socket close

Revert incorrect feedback widening of PermissionRequestResult

Rename client.on -> client.onLifecycle for cross-SDK consistency

Reformat src/types.ts after PermissionRequestResult revert

Address PR review comments from #1357

logLevel: don't impose any default, match C#/Go

Rename CopilotClientOptions.remote -> enableRemoteSessions for cross-SDK consistency