Fix optional MCP stdio server args#1344
Closed
Will-thom wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks for helping out, @Will-thom. We actually already made args optional on the runtime side, and were just waiting to pull in the new package, which we did this morning. With that, the fix is to make the properties in the SDK optional as well, rather than forcing an empty collection into existence. As such, I'm going to close this PR and let #1347 be the fix, but we appreciate your contribution, regardless. |
Author
|
Thanks for the explanation, @stephentoub. That makes total sense. I appreciate you taking the time to review the PR and clarify the intended SDK-side fix. Glad to hear the runtime-side change has landed, and closing this in favor of #1347 sounds good to me. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1231
Tests