C++: Add cpp/extraction-information query#21512
Draft
paldepind wants to merge 1 commit intogithub:mainfrom
Draft
C++: Add cpp/extraction-information query#21512paldepind wants to merge 1 commit intogithub:mainfrom
cpp/extraction-information query#21512paldepind wants to merge 1 commit intogithub:mainfrom
Conversation
e212be4 to
1af128f
Compare
1af128f to
4c525ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
cpp/extraction-informationquery similar to the$LANG/extraction-informationquery for Rust, Java, and C#.The implementation is consistent with the other languages. For now the query only includes metrics for resolved calls. The difference between this metric and the "Calls with explicit target" in
cpp/telemetry/extraction-metricsis that only call in the source are considered.This distinction is important for evaluating BMN with dependency installation. In the table below the first row shows the existing metric and the remaining rows show the new metric for the project
nmap.We believe that dependency installation has a detrimental effect on this project, but the existing metric looks like an improvement. This is because a lot of additional calls are added in dependencies which causes the number to increase. We the new metric the degradation in the database is clear.
Note that I didn't modify the existing
cpp/telemetry/extraction-metricsfor two reasons:cpp/extraction-informationfor consistency with other languages.cpp/telemetry/extraction-metricsis hooked up to some telemetry and dashboards?