Tests: Run slow scanArtifactsForTokens test in CI only by default#3874
Open
henrymercer wants to merge 1 commit intomainfrom
Open
Tests: Run slow scanArtifactsForTokens test in CI only by default#3874henrymercer wants to merge 1 commit intomainfrom
scanArtifactsForTokens test in CI only by default#3874henrymercer wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the artifact-scanner test suite to avoid running an expensive zip-extraction/token-scan test during typical local runs, while still exercising it in CI to preserve coverage of the regression scenario.
Changes:
- Adds an environment-gated condition so the slow “scanArtifactsForTokens finds token in debug artifacts” test runs by default only in CI.
- Introduces a local opt-in mechanism via
RUN_SLOW_TESTS=1. - Documents the rationale for the gating inline in the test file.
Show a summary per file
| File | Description |
|---|---|
src/artifact-scanner.test.ts |
Gates the slow artifact-scanning regression test to CI by default with a local opt-in environment variable. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "scanArtifactsForTokens finds token in debug artifacts" test takes 4.7 seconds to complete on my machine. Run it in CI only by default.
Here's proof that it actually runs.