Percent-encode VERS metacharacters in ToVersString output#16
Merged
Conversation
Version strings containing | or operator characters (>, <, =, !) are output verbatim by ToVersString, causing Parse(ToVersString(r)) to split or interpret them as constraint boundaries. Encodes these characters in the output and decodes them when parsing constraints, so roundtripping preserves the original range.
andrew
force-pushed
the
fix/vers-string-encoding
branch
from
7f65be8 to
f7a600e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`ToVersString` emits version strings verbatim. If a version contains `|`, `>`, `<`, `=`, or `!`, the output is ambiguous: `Parse(ToVersString(r))` can split or reinterpret these characters as constraint boundaries, widening or changing the range.
Adds `encodeVersVersion` which percent-encodes VERS metacharacters in version strings before they're placed in the output. Adds a matching decode step in `parseConstraintWithScheme` using `url.PathUnescape`, so roundtripping through `ToVersString` then `Parse` preserves the original range.