Bump registries to v0.6.0 and gate client with safehttp#20
Merged
Conversation
PURLs can carry a repository_url qualifier that NewFromPURL and BulkFetchPackages use as the fetch base URL. Wrap the underlying client with WithSafeHTTP so loopback, RFC1918, link-local and similar targets are refused at dial time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PURLs passed to this library can carry a
repository_urlqualifier thatregistries.NewFromPURLandBulkFetchPackagesuse as the fetch base URL. Since those PURLs may originate from manifests or other untrusted input, the registries client is now constructed withclient.WithSafeHTTP()so loopback, RFC1918, CGNAT, link-local and similar targets are refused at dial time.The bump also picks up populated
Version.Integrityfor pub, julia and nuget, which flows throughGetVersion/GetVersionsunchanged.registries_test.gospins up a 127.0.0.1 server, points a PURL'srepository_urlat it, and asserts the request never lands.The
clientsubpackage is imported directly becauseWithSafeHTTPisn't yet re-exported at theregistriesroot (git-pkgs/registries#28).