Skip to content

mingw-w64-llvm: update to 22.1.2#190

Open
gitforwindowshelper[bot] wants to merge 1 commit into
mainfrom
mingw-w64-llvm-22.1.2
Open

mingw-w64-llvm: update to 22.1.2#190
gitforwindowshelper[bot] wants to merge 1 commit into
mainfrom
mingw-w64-llvm-22.1.2

Conversation

@gitforwindowshelper
Copy link
Copy Markdown

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
@rimrul rimrul marked this pull request as ready for review March 27, 2026 08:26
@rimrul
Copy link
Copy Markdown
Member

rimrul commented Mar 27, 2026

/deploy

The workflow run was started.

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

I finally got around to figuring out why LLVM doesn't build anymore. It's fallout from msys2#27579. Both cmake and bsdtar expect libcrypto-3-arm64.dll to exist now, while ours is just called libcrypto-3.dll

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

We have the check-for-missing-dlls workflow to check for this, but it just happily prints "Need ARCH to be set" in git-sdk-arm64 and succeeds its checks without actually checking anything.

@dscho
Copy link
Copy Markdown
Member

dscho commented May 20, 2026

We have the check-for-missing-dlls workflow to check for this, but it just happily prints "Need ARCH to be set" in git-sdk-arm64 and succeeds its checks without actually checking anything.

One more reason to just switch to MSYS2's version of mingw-w64-openssl, right?

In the meantime, how about copying MSYS2's libcrypto-3-arm64.dll into our git-sdk-arm64, committing and pushing to main?

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

In the meantime, how about copying MSYS2's libcrypto-3-arm64.dll into our git-sdk-arm64, committing and pushing to main?

My thought for a quick workaround was a symlink between the two names. That would have the benefit of ensuring we're using the same version of the dll across all native tools.

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

I've created git-for-windows/build-extra#699 to hopefully fix the workflow.

@dscho
Copy link
Copy Markdown
Member

dscho commented May 20, 2026

In the meantime, how about copying MSYS2's libcrypto-3-arm64.dll into our git-sdk-arm64, committing and pushing to main?

My thought for a quick workaround was a symlink between the two names. That would have the benefit of ensuring we're using the same version of the dll across all native tools.

I wasn't sure whether symlinks work, but if they do, sure, let's do it!

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

We have the check-for-missing-dlls workflow to check for this

It wouldn't have caught this, because we don't ship bsdtar, cmake or any other native EXE from msys2 that depends on OpenSSL in Git for Windows.

@dscho
Copy link
Copy Markdown
Member

dscho commented May 20, 2026

We have the check-for-missing-dlls workflow to check for this

It wouldn't have caught this, because we don't ship bsdtar, cmake or any other native EXE from msys2 that depends on OpenSSL in Git for Windows.

All true! All the more reason to stop shadowing MSYS2's mingw-w64-openssl in git-sdk-64 and git-sdk-arm64.

@rimrul
Copy link
Copy Markdown
Member

rimrul commented May 20, 2026

I wasn't sure whether symlinks work, but if they do, sure, let's do it!

Both bsdtar and cmake seem happy with a symlink in my testing.

@dscho
Copy link
Copy Markdown
Member

dscho commented May 20, 2026

I wasn't sure whether symlinks work, but if they do, sure, let's do it!

Both bsdtar and cmake seem happy with a symlink in my testing.

Excellent! Let's do it, @rimrul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New mingw-w64-llvm version] LLVM: update to 22.1.2

2 participants