Harden database name handling#180
Merged
Merged
Conversation
Validate database names, quote database identifiers and use a parameter for pg_stat_activity.datname. Generate temporary database names with uuid4 to avoid one-second collisions. Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
ecarreras
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectiu
Endurir la gestió de noms de base de dades en
OpenERPService.create_database()iOpenERPService.drop_database().Refs #176
Canvis
uuid4en lloc deint(time.time()), evitant col·lisions dins el mateix segon.^[A-Za-z_][A-Za-z0-9_]*$CREATE DATABASEiDROP DATABASE.pg_stat_activity.datnamepassa a usar paràmetre SQL en lloc de format string.db_name, cobrint valors via configuració/CLI.Validació
Executat correctament:
No he executat
mamba specperquèmambano està instal·lat en aquest entorn local.Nota: Python 3.12 sobre
masterencara queda bloquejat per #175 (impeliminat). Aquesta PR no depèn funcionalment de PostgreSQL real per als tests afegits.