feat: run installed module dependency tests#174
Conversation
Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
53ac927 to
6fbb14b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a CLI mode to run tests for an addon’s full dependency chain by first installing the selected addon(s), plus a utility helper to expand modules with dependencies (with unit tests) and README documentation for the new flag.
Changes:
- Add
--all-installed-testsCLI flag to pre-install selected modules and then run tests for the full dependency chain (base→ target). - Introduce
utils.get_modules_and_dependencies()helper to expand + dedupe modules and dependencies, returning them in dependency order. - Add unit tests for dependency expansion/deduplication and document the new CLI option in
README.rst.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
destral/cli.py |
Adds the new CLI flag and logic to install selected modules before testing the expanded dependency chain. |
destral/utils.py |
Exports and implements get_modules_and_dependencies() to expand requested modules with their dependencies. |
tests/test_utils.py |
Adds unit tests validating dependency expansion order and deduplication. |
README.rst |
Documents the new --all-installed-tests option behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
|
He revisat els 2 comentaris de Copilot i he aplicat correcció real al PR. Commit pujat: Canvis:
Validació local:
CI GitHub del commit nou:
He marcat els dos review threads com a resolts. Únic bloqueig local menor: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Skip per-suite module installs when the database was already provisioned for installed module tests. Install requirement files once per expanded module to avoid repeated dependency requirement installs. Co-authored-by: Eduard Carreras <ecarreras@gisce.net>
|
He revisat la nova review de Copilot i he aplicat correcció real al PR. Commit pujat: Canvis:
Validació local:
He resolt els dos review threads nous de Copilot. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resumen
--all-installed-testsal CLI de Destral.-m <modulo> --all-installed-tests, Destral instala primero el módulo indicado y después ejecuta los tests de toda su cadena de dependencias en orden, debasehasta el módulo objetivo.Validación
git diff --check/home/openclaw/.pyenv/versions/erp2/bin/python -m unittest discover tests