Skip to content

suggestion for delete metadataset endpoint#489

Open
ckaipf wants to merge 26 commits into
developfrom
add-delete-submitted-record-function
Open

suggestion for delete metadataset endpoint#489
ckaipf wants to merge 26 commits into
developfrom
add-delete-submitted-record-function

Conversation

@ckaipf
Copy link
Copy Markdown
Contributor

@ckaipf ckaipf commented Dec 19, 2022 •
edited
Loading

PR to discuss how to implement an delete MetaDataSet endpoint

General

  • should only be allowed for site admins

Implementation: delete MetaDataSets and associated files from storage

  • If MetaDataSet has MetaDatumRecords associated with File
    • Remove file from storage and File object from database
  • Delete MetaDataSet
    • MetaDatumRecords are deleted via cascade (MetaDataSet is parent of MetaDatumRecord)
    • ServiceExecutions are deleted via cascade (MetaDataSet is parent of ServiceExecution)

Open questions

  • empty Submission (just one MetaDataSet which was deleted)
  • should MetaDatum be a parent of File (conflicts expected)

@ckaipf ckaipf changed the title suggestion for endpoint suggestion for delete metadataset endpoint Dec 19, 2022
ckaipf added 15 commits February 13, 2023 09:46
@ckaipf
Merge branch 'develop' of https://github.com/ghga-de/datameta into ad…
f6be1c1 
…d-delete-submitted-record-function
@ckaipf
update openapi.yaml
7927f26
@ckaipf
add cascade option to relationship MetaDataSet -> MetaDatumRecord
c539cdc 
MetaDataSet is parent/owner of MetaDatumRecord, if a MetaDataSet is removed/dissociated
its associated MetaDatumRecords
have no meaning
@ckaipf
same applies to MetaDatumRecord -> File
3a56d5a
@ckaipf
add route
496b124
@ckaipf
reverse the relationship MetadatumRecord is parent of File
e9138c8
@ckaipf
add auth function for delete submitted metadatasets
6b54549
@ckaipf
add response object
b481eea
@ckaipf
add delete endpoint draft
1a38043
@ckaipf
add a test draf for delete endpoint
de50c37
@ckaipf
update response schemas
b7c121c
@ckaipf
update endpoint
d8dd626
@ckaipf
add fixture for metadatasets which has no associated file record
a1a5df6
@ckaipf
remove associated service_executions with cascade,
9773a8d 
MetaDatumRecord is Child of File
No cascada for (MetaDatumRecord, File)
@ckaipf
update test name
ce15e28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ckaipf