Skip to content

Refactor/security split 20220303#480

Open
cschu wants to merge 36 commits into
developfrom
refactor/security_split_20220303
Open

Refactor/security split 20220303#480
cschu wants to merge 36 commits into
developfrom
refactor/security_split_20220303

Conversation

@cschu
Copy link
Copy Markdown
Contributor

@cschu cschu commented Mar 4, 2022

  • splits token- and password-related security functions into submodules security.tokenz resp. security.pwdz
  • to be merged after Feature/login tracking 478 #479 (sub-branch of feature/login_tracking_478)
  • revision needed - clashes with module import in tests (currently solved with redundant imports of the submodule-functions into security/__init__.py, which defeats the purpose of the split)

cschu and others added 30 commits October 29, 2021 16:51
@cschu
starting to address issue #478
f40e4a7
@cschu
version bump -> 1.1.0
b58787d
@cschu
ConnectionRefusedError are now caught when trying to send email
0ead5ef
@cschu
minor fix
4af403f
@cschu
pleasing flake8
8b74fcf
@cschu
Merge branch 'develop' into feature/login_tracking_478
a8ffdd9
@cschu
implemented suggestions from code review
d7af75e 
* added informative log warnings when login attempt fails and/or user is blocked
* moved maximum number of allowed failed login attempts to appsettings:security_max_failed_logins
* failed login attempts are now cleared when user logs in successfully
@cschu
Merge branch 'feature/login_tracking_478' of https://github.com/ghga-…
56613b2 
…de/datameta into feature/login_tracking_478
@cschu
added get_db() to FixtureManager in order to be able to check databas…
5d9c8e4 
…e from a test
@cschu
added db-flush after dealing with invalid login attempt, renamed secu…
a1bc4da 
…rity_max_failed_login_attempts setting
@cschu
added login_tracking integration test
d9a1327
@cschu
Merge branch 'develop' into feature/login_tracking_478
09cf5bb
@cschu
refactored appsettings:put -> settings.set_setting
a57fe63
@cschu
revised revision message
21e8474
@cschu
cosmetics
0c2533a
@cschu
fixed: date_value -> time_value
0f0f636
@cschu
added set_application_setting() function to BaseIntegrationTest
17ba902
@cschu
refactored test to use BaseIntegrationTest.set_application_setting()
c7c454f
@cschu
removed get_db() function
f4f20a9
@cschu
pleasing flake8
973eac4
@cschu
removed unneccessary list-comprehension
cf0a5ea
@lkuchenb
Refactor login attempts deletion
9ec9b46
@cschu @lkuchenb
Apply suggestions from code review
3da759f 
Co-authored-by: Leon Kuchenbecker <leon.kuchenbecker@uni-tuebingen.de>
@cschu
pleasing flake8
ca0a62d
@cschu
pleasing mypy
218500a
@cschu
added failed login attempt tracking to expired apikey and group-misma…
e2fb375 
…tch scenarios
@cschu
refactor: revalidate_user now uses new transaction for login attempt …
7bf43bf 
…tracking
@cschu
added test for apikey-based login tracking
95833eb
@cschu
Merge branch 'develop' into feature/login_tracking_478
5b560ff
@cschu
minor: whitespace
6597d01
@cschu cschu requested a review from lkuchenb March 4, 2022 09:26
@cschu cschu changed the base branch from main to develop March 31, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkuchenb lkuchenb Awaiting requested review from lkuchenb

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Code Review Do Not Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cschu @lkuchenb