llama-bench: fix accumulated load_time in perf timings#21794
Open
abhinavuser wants to merge 1 commit intoggml-org:masterfrom
Open
llama-bench: fix accumulated load_time in perf timings#21794abhinavuser wants to merge 1 commit intoggml-org:masterfrom
abhinavuser wants to merge 1 commit intoggml-org:masterfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Author
|
not AI generated, i traced the bug through the code, each new context copies t_start_us from the model's original load timestamp (llama-context.cpp line 35), so when the model is reused across bench iterations the load_time just keeps growing |
am17an
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix accumulated load_time in llama_perf_context_print when running llama-bench with multiple parameter sets (e.g.
-n 4,8,16,32).The load_time keeps growing because each new context inherits t_start_us from the model's original load timestamp, but the model is reused across runs. Added llama_perf_context_reset(ctx) after context creation to reset the timing baseline per iteration.
Fixes #9286
Additional information
Spotted this while benchmarking with verbose output — the load_time went from ~1s to ~33s across 7 runs even though the model was only loaded once.
Requirements