CUDA: only init NCCL for setups with multi GPU#21761
Open
EldarBorge wants to merge 1 commit intoggml-org:masterfrom
Open
CUDA: only init NCCL for setups with multi GPU#21761EldarBorge wants to merge 1 commit intoggml-org:masterfrom
EldarBorge wants to merge 1 commit intoggml-org:masterfrom
Conversation
Contributor
|
#21746 should be a better fix. |
Author
|
You are probably right, your fix is too advanced for me to understand! Let's await @ggerganov , but feel free to close my PR if it's not a good fix. 🙂 |
|
Is NCCL always initialized now? or is it just for |
Author
always after b8738 is my understanding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Skips NCCL if the setup is single GPU, i.e. only initializes NCCL if GPU count is more than 1.
This reduces VRAM on single GPU setups that was introduced in b8738.
Fixes #21759
Tested locally and reduces VRAM both idle and under load to pre b8738 levels on my setup.
Requirements