vulkan: Support asymmetric FA in coopmat2 path#21753
Open
jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
Open
vulkan: Support asymmetric FA in coopmat2 path#21753jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
jeffbolznv wants to merge 1 commit intoggml-org:masterfrom
Conversation
There has been some recent interest/experimentation with mixed quantization types for FA. I had originally designed the cm2 FA shader with this in mind (because I didn't realize it wasn't supported at the time!), this change adds the missing pieces and enables it. Also support Q1_0 since people have been trying that out (seems crazy, but who knows). We should be able to do similar things in the coopmat1/scalar path, but there's another change open against the scalar path and I don't want to conflict.
Collaborator
|
I have not run it, but at first glance the code looks like iq4_nl is missing. Thanks for providing this, I will see what testing I can get out of this. But from the testing I did with q1_0 with nkvo, q1_0 hurts the performance of the model too much. It is more or less equivalent to a thirding or quatering of model parameter count. |
Contributor
Author
|
I took out iq4nl because I wanted to avoid allocating and initializing the shared memory table if it's not used. Is this something people actually use? If so, I can put it back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
There has been some recent interest/experimentation with mixed quantization types for FA. I had originally designed the cm2 FA shader with this in mind (because I didn't realize it wasn't supported at the time!), this change adds the missing pieces and enables it.
Also support Q1_0 since people have been trying that out (seems crazy, but who knows).
We should be able to do similar things in the coopmat1/scalar path, but there's another change open against the scalar path and I don't want to conflict.
Requirements