cli: improve auto-completion code#21745
Open
matthiasstraka wants to merge 1 commit intoggml-org:masterfrom
Open
cli: improve auto-completion code#21745matthiasstraka wants to merge 1 commit intoggml-org:masterfrom
matthiasstraka wants to merge 1 commit intoggml-org:masterfrom
Conversation
CISC
reviewed
Apr 11, 2026
matthiasstraka
force-pushed
the
cli-string-cleanup
branch
from
d4c9faa to
719337b
Compare
ngxson
approved these changes
Apr 11, 2026
CISC
reviewed
Apr 11, 2026
| if (string_starts_with(rel_pattern, '~')) { | ||
| const char * home = std::getenv("HOME"); | ||
| if (home && home[0]) { | ||
| rel_pattern = std::string(home) + rel_pattern.substr(1); |
Member
There was a problem hiding this comment.
Suggested change
| rel_pattern = std::string(home) + rel_pattern.substr(1); | |
| rel_pattern = home + rel_pattern.substr(1); |
|
|
||
| // TODO?: Make this reusable, enums, docs | ||
| static const std::array<const std::string, 7> cmds = { | ||
| static const std::array<std::string_view, 7> cmds = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR cleans up the code for cli auto-completion and makes it more efficient.
It also adds a
string_starts_withhelper function - compatible with future C++20 upgrades.There are no side-effects outside the
auto_completion_callbackfunction.References
#19985
Requirements