Skip to content

Use clj-kondo config inside project, add :lint-as #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sritchie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use clj-kondo config inside project, add :lint-as #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clj-kondo/config.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{:config-paths ["../resources/clj-kondo.exports/com.gfredericks/test.chuck"]}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ pom.xml.asc
*.class
/.lein-*
/.nrepl-port
.clj-kondo/.cache
7 changes: 6 additions & 1 deletion resources/clj-kondo.exports/com.gfredericks/test.chuck/config.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
{:hooks
{:lint-as
{com.gfredericks.test.chuck.generators/for clojure.core/for
Copy link
Copy Markdown
Author

@sritchie sritchie Jan 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I THINK these are correct, but please let me know if not.

Copy link
Copy Markdown
Owner

@gfredericks gfredericks Jan 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, depends on what the assumption is

e.g., for has this :parallel clause, will that mess anything up?

(gen'/for [:parallel [n1 gen/nat
                      n2 gen/nat]
           :when ^{:max-tries 20} (coprime? n1 n2)
           :let [product (* n1 n2)]]
  {:n product, :factors [n1 n2]})```

Copy link
Copy Markdown
Author

@sritchie sritchie Jan 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good call. I'll do a better job here and write a proper hook that we can ship with the library. Should get to this soon, thank you for the review!

com.gfredericks.test.chuck.generators/for-all clojure.core/for
com.gfredericks.test.chuck.clojure-test/for-all clojure.core/for}

:hooks
{:analyze-call
{com.gfredericks.test.chuck.clojure-test/checking
clj-kondo.com.gfredericks.test.chuck.checking/checking}}}