fix(tests): Fix flaky test_issue_multiple_status_changes batch timing#109020
Closed
fix(tests): Fix flaky test_issue_multiple_status_changes batch timing#109020
Conversation
Change max_batch_time from 1 to sys.maxsize to prevent time-based batch flushing from splitting messages into multiple batches on slow CI. Fixes #108997
Member
Author
|
maybe relax a bit and make it a more reasonable amount of time, and add a code comment about why |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_batch_timefrom1tosys.maxsizeto prevent time-based batch flushing from splitting messages into multiple batches on slow CI, matching the pattern used bytest_issue_occurrence_status_change_mixFixes #108997
Test plan