fix(tests): Reset flusher isolation scope level to fix test pollution#109007
Closed
fix(tests): Reset flusher isolation scope level to fix test pollution#109007
Conversation
The span consumer flusher thread sets `scope.level = "warning"` on the sentry_sdk isolation scope. In tests, the flusher runs as a thread (not a subprocess), so this modification leaks into subsequent tests and overrides event levels set in the thread leak detection tests. Wrap test body in try/finally to ensure flusher cleanup, and reset the isolation scope level after joining the flusher thread. Fixes #108908
Member
Author
|
Superseded by #109105 which uses an autouse conftest fixture instead of per-test try/finally cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope.level = "warning"on the sentry_sdk isolation scope. In tests, the flusher runs as a thread (not a subprocess), so this modification leaks into subsequent tests.try/finallyto ensure flusher cleanup, and reset the isolation scope level after joining the flusher thread.test_schema_validator_rejects_string_timestampswhich has the same pattern.Fixes #108908
Test plan