fix(tests): Fix flaky test_snuba_data_transaction timestamp drift#108972
Closed
fix(tests): Fix flaky test_snuba_data_transaction timestamp drift#108972
Conversation
The test compared nodestore and Snuba timestamps, but before_now() calls happen at different real-time moments, causing off-by-one second differences. Fix by freezing time to make all timestamp computations deterministic. Fixes #108963
Member
Author
|
Combined into #109096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_snuba_data_transactionby freezing timebefore_now()calls at different real-time moments caused off-by-one second differencesfreeze_time()makes all timestamp computations deterministicFixes #108963
Test plan