refa(devcontainer): rework to use mise for fast switching#2948
Merged
Conversation
e22e805 to
41504fa
Compare
048daa5 to
d6cd2e6
Compare
9d2348d to
b6e5dbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rework comes with 3 nice improvements:
1. Mise for fast switching between modern ruby versions (including jruby)
The image by default ships with the latest ruby (4.0.3 at the moment), and then switching to older rubies is super easy:
All that in less than 20s.
For legacy Rubies, we still use dedicated dev container builds, no way around this.
2. Improved e2e spec setup in CI
Supports running against 4.x and 3.x rubies and uses pre-built images from the
build_imagesworkflow. We also no longer depend onforemanfor running e2e test apps, and instead we just usemisescripts.3. Versioned dev container images with workflow manual trigger enabled
Our build images workflow publishes versioned images based on
.devcontainer/VERSIONso it's easier to maintain this setup now. Especially when a topic branch is used to make some tweaks, like this very PR/branch.