feat(sentry-sidekiq): add report_errors_via_rails config#2701
Closed
lucasmazza wants to merge 3 commits into
Closed
feat(sentry-sidekiq): add report_errors_via_rails config#2701lucasmazza wants to merge 3 commits into
report_errors_via_rails config#2701lucasmazza wants to merge 3 commits into
Conversation
Contributor
Author
|
I'm testing this with our Rails app but the solution isn't quite there yet - Rails reporter is ignoring the exception because the retry check has marked it as |
23857f9 to
75b5ac9
Compare
Collaborator
@lucasmazza did you manage to figure it out? |
Contributor
Author
|
@solnic nope - I couldn't figure this out and changed our app code to stop using |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 144 144
Lines 5657 5664 +7
=======================================
+ Hits 5505 5512 +7
Misses 152 152
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
report_errors_via_railsconfig tosentry-sidekiqto fix #2698. When this is enabled, exceptions reported by the Sidekiq error handler will first go throughRails.error(andRails::Sentry::ErrorSubscriber) before being sent to Sentry.This allow exceptions from Sidekiq jobs to use the same context from
Rails.error.set_contextorRails.error.add_middleware(available on Rails 8.1+)Fixes RUBY-92