Tests for Rails.logger when :logger patch is enabled#2659
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
==========================================
- Coverage 97.48% 94.09% -3.39%
==========================================
Files 134 134
Lines 5167 5135 -32
==========================================
- Hits 5037 4832 -205
- Misses 130 303 +173
🚀 New features to boost your workflow:
|
Collaborator
Author
|
@sl0thentr0py no idea what's going on with ruby head yet so pls ignore it again 🙃 |
sl0thentr0py
requested changes
Jun 26, 2025
8c1d65f to
b3fed53
Compare
Collaborator
Author
|
@sl0thentr0py OK I moved the rake tasks stuff to the toplevel |
sl0thentr0py
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for
Rails.loggerwhen:loggerpatch is enabled. I also add a unified way of defining spec tasks for our projects so that I can easily add an isolated spec to sentry-rails.Refs #2644
#skip-changelog