Fix spec suite on CI#2640
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2640 +/- ##
==========================================
+ Coverage 94.45% 96.60% +2.15%
==========================================
Files 133 133
Lines 5101 5126 +25
==========================================
+ Hits 4818 4952 +134
+ Misses 283 174 -109
🚀 New features to boost your workflow:
|
sl0thentr0py
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes our spec suite better but I'm doing this because our tests started to fail recently with Excon adapter from webmock trying to mutate an array that is defined in Excon. This led me to discovering that load order of spec_helper is significant and we want to load it as soon as possible to get more consistent environment setup.
So this PR:
--require spec_helperto.rspecspec_helperfrom sentry-ruby spec suiteisolated_specstask as a regularRSpec::Core::Taskwhich is another small win here.rspecso that we have the same settings when running isolated and regular specsNot strictly needed but:
progressbecause it's faster, and you can see various warnings#skip-changelog