Skip to content

Fix flaky spec for jruby #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solnic merged 2 commits into from
May 21, 2025
Merged

Fix flaky spec for jruby #2635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
951a1d3
fix(tests): Increase latency tolerance in SentryContextServerMiddlewa…
solnic May 21, 2025
d8bbb2c
chore(workflows): Set timeout for all test workflows to 10 minutes
solnic May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sentry_delayed_job_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
working-directory: sentry-delayed_job
name: Ruby ${{ matrix.ruby_version }}, options - ${{ toJson(matrix.options) }}
runs-on: ubuntu-latest
timeout-minutes: 10
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-delayed_job/Gemfile
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_opentelemetry_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
working-directory: sentry-opentelemetry
name: Ruby ${{ matrix.ruby_version }} & OpenTelemetry ${{ matrix.opentelemetry_version }}, options - ${{ toJson(matrix.options) }}
runs-on: ubuntu-latest
timeout-minutes: 10
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-opentelemetry/Gemfile
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_rails_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
working-directory: sentry-rails
name: Ruby ${{ matrix.ruby_version }} & Rails ${{ matrix.rails_version }}, options - ${{ toJson(matrix.options) }}
runs-on: ubuntu-latest
timeout-minutes: 10
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-rails/Gemfile
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_resque_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
working-directory: sentry-resque
name: Ruby ${{ matrix.ruby_version }}, options - ${{ toJson(matrix.options) }}
runs-on: ubuntu-latest
timeout-minutes: 10
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-resque/Gemfile
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/sentry_sidekiq_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
working-directory: sentry-sidekiq
name: Ruby ${{ matrix.ruby_version }} & Sidekiq ${{ matrix.sidekiq_version }}, options - ${{ toJson(matrix.options) }}
runs-on: ubuntu-latest
timeout-minutes: 10
env:
RUBYOPT: ${{ matrix.options.rubyopt }}
BUNDLE_GEMFILE: ${{ github.workspace }}/sentry-sidekiq/Gemfile
Expand Down
2 changes: 1 addition & 1 deletion sentry-sidekiq/spec/sentry/sidekiq/sentry_context_middleware_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def timecop_delay
expect(trace[:data]['messaging.message.id']).to eq('123456')
expect(trace[:data]['messaging.destination.name']).to eq('default')
expect(trace[:data]['messaging.message.retry.count']).to eq(0)
expect(trace[:data]['messaging.message.receive.latency']).to be_within(1).of(expected_latency)
expect(trace[:data]['messaging.message.receive.latency']).to be_within(3).of(expected_latency)
end

if MIN_SIDEKIQ_6
Expand Down
Loading