Skip to content

Inherit secrets to fix CODECOV_TOKEN not present in sub actions#2628

Merged
sl0thentr0py merged 1 commit into
masterfrom
neel/fix-codecov-secret-inherit
May 15, 2025
Merged

Inherit secrets to fix CODECOV_TOKEN not present in sub actions#2628
sl0thentr0py merged 1 commit into
masterfrom
neel/fix-codecov-secret-inherit

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

without this, CODECOV_TOKEN is not present in the sub workflows and coverage uploading fails
https://github.com/getsentry/sentry-ruby/actions/runs/15042765819/job/42278160770#step:7:240

#skip-changelog

@sl0thentr0py sl0thentr0py requested a review from solnic May 15, 2025 11:18
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.15%. Comparing base (db975df) to head (b482819).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
+ Coverage   64.11%   64.15%   +0.03%     
==========================================
  Files         123      127       +4     
  Lines        4724     4918     +194     
==========================================
+ Hits         3029     3155     +126     
- Misses       1695     1763      +68     
Components Coverage Δ
sentry-ruby 59.78% <53.44%> (-4.29%) ⬇️
sentry-rails 60.26% <68.57%> (-5.82%) ⬇️
sentry-sidekiq 96.57% <94.73%> (-0.59%) ⬇️
sentry-resque 94.44% <100.00%> (+51.74%) ⬆️
sentry-delayed_job 95.65% <ø> (+63.05%) ⬆️
sentry-opentelemetry 99.31% <ø> (+58.25%) ⬆️

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) May 15, 2025 11:29
@sl0thentr0py sl0thentr0py merged commit c509ce1 into master May 15, 2025
263 of 264 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-codecov-secret-inherit branch May 15, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants