Skip to content

Fix flaky spec#2614

Merged
solnic merged 1 commit into
masterfrom
fix-flaky-spec
May 2, 2025
Merged

Fix flaky spec#2614
solnic merged 1 commit into
masterfrom
fix-flaky-spec

Conversation

@solnic
Copy link
Copy Markdown
Collaborator

@solnic solnic commented May 2, 2025

Addresses this failure from jruby:

Failures:

  1) Sentry::Sidekiq::SentryContextServerMiddleware with tracing enabled span data for Queues module adds a queue.process transaction with correct data
     Failure/Error: expect(trace[:data]['messaging.message.receive.latency']).to eq(expected_latency)

       expected: 86400000
            got: 86399999

       (compared using ==)
     # ./spec/sentry/sidekiq/sentry_context_middleware_spec.rb:93:in 'block (4 levels) in <top (required)>'

#skip-changelog

@solnic solnic requested a review from sl0thentr0py May 2, 2025 09:24
@solnic solnic merged commit 407ea0b into master May 2, 2025
138 of 139 checks passed
@solnic solnic deleted the fix-flaky-spec branch May 2, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants