Skip to content

fix(cohere): Stop setting transaction status when child span fails#6300

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/cohere/transaction
May 20, 2026
Merged

fix(cohere): Stop setting transaction status when child span fails#6300
alexander-alderman-webb merged 1 commit into
masterfrom
webb/cohere/transaction

Conversation

@alexander-alderman-webb
Copy link
Copy Markdown
Contributor

@alexander-alderman-webb alexander-alderman-webb commented May 20, 2026

Description

Stop modifying the transaction, since the transaction may not be managed by cohere.

Issues

Reminders

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Codecov Results 📊

282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.71s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 14892 uncovered lines.
✅ Project coverage is 33.42%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
cohere.py 87.90% ⚠️ 15 Missing and 14 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    32.43%    33.42%    +0.99%
==========================================
  Files          190       190         —
  Lines        22369     22367        -2
  Branches      7594      7594         —
==========================================
+ Hits          7254      7475      +221
- Misses       15115     14892      -223
- Partials       694       744       +50

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review May 20, 2026 08:19
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner May 20, 2026 08:19
@alexander-alderman-webb alexander-alderman-webb merged commit a85ef43 into master May 20, 2026
157 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/cohere/transaction branch May 20, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants