perf(traces): Cache valid span statuses in a module-level frozenset#6208
Merged
ericapisani merged 1 commit intomasterfrom May 5, 2026
Merged
perf(traces): Cache valid span statuses in a module-level frozenset#6208ericapisani merged 1 commit intomasterfrom
ericapisani merged 1 commit intomasterfrom
Conversation
Avoids rebuilding the set on every `set_status` call by computing it once at module load time.
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.73s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 15002 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sl0thentr0py
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
statussetter onStreamedSpanwas reconstructing a set from theSpanStatusenum on every invocation. In high-throughput tracing workloads this is a hot path, so caching the values in a module-levelfrozensetavoids repeated allocations.Fixes #6207
Fixes PY-2403
Using the following benchmarking script:
I was able to confirm the small bump in performance with this change:
Run 1:
Run 2:
Run 3: