feat(integrations): Add integration for `aiomysql` by tonal · Pull Request #4703 · getsentry/sentry-python

tonal · 2025-08-14T09:43:14Z

Add support for aiomysql to the SDK.

antonpirker · 2025-09-11T14:55:25Z

Hey @tonal thanks for the PR, great work! Could you address the cursor comments above?

alexander-alderman-webb · 2025-10-09T08:26:31Z

+"""
+Adapted from module sentry_sdk.integrations.asyncpg
+"""


Hi @tonal ,

Thanks for the contribution, much appreciated!

Can you add unit tests for the integration as well? You can probably adapt them from the asyncpg tests.

github-actions · 2026-04-12T10:02:38Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Integrations

Add integration for aiomysql by tonal in #4703

Instrument pyreqwest tracing by servusdei2018 in #5682

Other

(ai) Redact base64 data URLs in image_url content blocks by ericapisani in #5953
(ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994
(litellm) Add async callbacks by alexander-alderman-webb in #5969

Bug Fixes 🐛

Anthropic

Capture exceptions for stream() calls by alexander-alderman-webb in #5950
Stop setting transaction status when child span fails by alexander-alderman-webb in #5717
Only finish relevant spans in .create() patches by alexander-alderman-webb in #5716

Pydantic Ai

Adapt import for new library versions by alexander-alderman-webb in #5984
Use first-class hooks when available by alexander-alderman-webb in #5947

Other

(huggingface_hub) Stop setting transaction status when a child span fails by Zenithatic in #5952
(litellm) Avoid double span exits when streaming by alexander-alderman-webb in #5933
(wsgi) Respect HTTP_X_FORWARDED_PROTO in request.url construction by sl0thentr0py in #5963

Internal Changes 🔧

Litellm

Replace mocks with httpx types in rate-limit test by alexander-alderman-webb in #5975
Replace mocks with httpx types in embedding tests by alexander-alderman-webb in #5970
Replace mocks with httpx types in nonstreaming completion() tests by alexander-alderman-webb in #5937
Remove dead attributes by alexander-alderman-webb in #5985

Other

(ai) Remove gen_ai.tool.type span attribute by ericapisani in #5964
(anthropic) Separate sync and async .create() patches by alexander-alderman-webb in #5715
(openai) Split token counting by API for easier deprecation by ericapisani in #5930
(openai-agents) Remove error attributes by alexander-alderman-webb in #5986
(opentelemetry) Ignore mypy error by alexander-alderman-webb in #5927
🤖 Update test matrix with new releases (04/13) by github-actions in #5983
Fix license metadata in setup.py by sl0thentr0py in #5934
Update validate-pr workflow by stephanie-anderson in #5931

Other

release: 2.58.0 by ericapisani in ce445d96
Handle None span context in the span processor and pin tokenizers version for anthropic tests on Python 3.8 by alexander-alderman-webb in #5967

_{🤖 This preview updates automatically when you update the PR.}

Rewrite the aiomysql integration to fix issues raised in PR getsentry#4703: - Patch Cursor.execute and Cursor.executemany instead of Connection.query - Make _wrap_connect async (await inside span context) - Handle bytes/bytearray queries from executemany's internal batching - Normalize query text using " ".join(query.split()) for performance - Protect _sentry_skip_next_execute flag with try/finally to prevent leakage - Remove dead _wrap_cursor and unused _record context manager Add 17 end-to-end tests covering connect, execute, executemany, record_params, cursor iteration, connection pools, query source, span origin, and normalization. Update CI configuration: tox.ini envlist, GitHub Actions workflow with MySQL service container, and test suite config. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

- Add AioMySQLIntegration to _AUTO_ENABLING_INTEGRATIONS and _MIN_VERSIONS (fixes sentry bot: auto-enabling and minimum version check) - Protect _sentry_skip_next_execute flag with try/finally in _wrap_executemany and do NOT reset it in _wrap_execute (fixes cursor bot: flag resets prematurely on non-INSERT row-by-row fallback) - Normalize query text using " ".join(query.split()) instead of re.sub for performance - Fix duplicate YAML keys bug in test_group.jinja template that caused postgres service to be silently dropped when mysql service is added - Add test for non-INSERT executemany (row-by-row fallback) Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

# Conflicts: # .github/workflows/test-integrations-dbs.yml # sentry_sdk/integrations/aiomysql.py # tests/integrations/aiomysql/test_aiomysql.py

The leftover {% if needs_mysql %} block created duplicate 'services:' and 'env:' keys, causing YAML parsers to silently overwrite earlier definitions. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

…ction Fixes sentry bot review comment on PR getsentry#4703. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

tonal · 2026-04-13T05:20:54Z

@antonpirker All cursor comments are now addressed! Here is a summary of all the fixes:

Integration now patches Cursor.execute and Cursor.executemany instead of Connection.query (the original approach used a non-standard internal API)
_wrap_connect is now properly async (awaits inside the span context)
Query normalization handles bytes/bytearray` from executemany's internal batching
_sentry_skip_next_execute flag is protected with try/finally in _wrap_executemany and is no longer reset inside _wrap_execute — this prevents double-recording on non-INSERT row-by-row fallback
Removed the dead _wrap_cursor function
Integration added to _AUTO_ENABLING_INTEGRATIONS and _MIN_VERSIONS
Used public cursor.connection instead of private cursor._connection
Fixed duplicate YAML keys bug in the CI workflow template that silently dropped the postgres service when mysql was also present

@alexander-alderman-webb
18 end-to-end tests added and passing. 🙏

…tional args Fixes cursor bot comment: positional args to aiomysql.connect are now captured correctly for span metadata. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

- Run ruff format on aiomysql.py to satisfy lint checks - Add cryptography to aiomysql tox deps (required for MySQL 8.0 caching_sha2_password authentication in CI) Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

…d reconnects - Patch Connection._connect instead of aiomysql.connect so that pool.py (which imports connect directly from .connection) and reconnects are all instrumented. - Connection._connect has no arguments beyond self; read host/port/db/user directly from connection properties. - Add assertions to test_connection_pool verifying connect spans are created for each pooled connection. - Use `is not None` checks in _set_db_data to avoid skipping falsy but valid values (fixes cursor bot comment). - Suppress MySQL warnings in test fixture via warnings.catch_warnings(). - Replace deprecated enable_tracing=True with traces_sample_rate=1.0 in tests. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

… guards Address cursor bot comment: CONNECT WRAPPER LACKS NULL GUARDS. Replace direct span.set_data calls with _set_db_data(span, self) to reuse the same getattr/is-not-None logic used for query spans. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

antonpirker · 2026-04-21T08:25:46Z

@antonpirker All cursor comments are now addressed! Here is a summary of all the fixes

Great work @tonal! But i am no longer at Sentry, so @alexander-alderman-webb will take care of this. You are in good hands with him :-)

Resolve merge conflicts in auto-generated files (tox.ini, package_dependencies.jsonl, releases.jsonl, CI workflows) by taking upstream versions and regenerating with aiomysql config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Include fix for compromised transitive dependency (getsentry#6257). Regenerate tox.ini and CI workflows with aiomysql config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Replace record_sql_queries with record_sql_queries_supporting_streaming to support span streaming (addresses sentry bot review comment). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

- Use set_attribute for StreamedSpan, set_data for regular Span - Branch _wrap_connect: traces.start_span with attributes when streaming, start_span with set_data otherwise (following asyncpg pattern) - Import StreamedSpan and has_span_streaming_enabled Addresses sentry bot and cursor bot review comments (HIGH severity). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a0143fd. Configure here.}

…mocks - Call add_query_source inside context for StreamedSpan, outside for regular Span (following asyncpg pattern) - Fix tests to mock record_sql_queries_supporting_streaming instead of record_sql_queries Addresses cursor bot review comments. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

tonal · 2026-05-12T09:09:37Z

@alexander-alderman-webb Hi! I've resolved all the bot review comments (span streaming support, StreamedSpan compatibility, test mocks) and merged the latest master. The PR is ready for review when you have a chance. Thanks!

alexander-alderman-webb

Looks good me! Please resolve the conflicts in tox.ini as well and then I'd approve and merge

alexander-alderman-webb · 2026-05-15T11:59:11Z

-        # Set health checks to wait until postgres has started
        options: >-
          --health-cmd pg_isready
          --health-interval 10s
          --health-timeout 5s
          --health-retries 5
-        # Maps tcp port 5432 on service container to the host


Please avoid changes in unrelated files 🙏

alexander-alderman-webb · 2026-05-15T12:03:02Z


 _AUTO_ENABLING_INTEGRATIONS = [
    "sentry_sdk.integrations.aiohttp.AioHttpIntegration",
+    "sentry_sdk.integrations.aiomysql.AioMySQLIntegration",


We would wait until the integration has been tested over a few versions before adding the integration to be auto-enabled.

Could you please remove the integration from auto-enabling list? 🙏

alexander-alderman-webb · 2026-05-15T12:14:17Z

I also just ran our checks and the lint and the new tests are failing. These block merging the PR.

You can run the linter locally using the following command:

ruff format --check tests sentry_sdk

integration for aiomysql

878dc5b

tonal requested a review from a team as a code owner August 14, 2025 09:43

seer-by-sentry Bot reviewed Aug 14, 2025

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

seer-by-sentry Bot reviewed Aug 14, 2025

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

This comment was marked as outdated.

Sign in to view

tonal added 3 commits August 20, 2025 16:24

Drop _wrap_cursor_creation in integration aiomysql.py

29b4e85

Potential KeyError in _wrap_connect

28e79b6

Merge branch 'getsentry:master' into patch-2

950032f

This comment was marked as outdated.

Sign in to view

sentrivana linked an issue Aug 25, 2025 that may be closed by this pull request

'Span' object has no attribute '_context_manager_state' #4718

Closed

sentrivana removed a link to an issue Aug 25, 2025

'Span' object has no attribute '_context_manager_state' #4718

Closed

Merge branch 'master' into patch-2

421abfa

This comment was marked as outdated.

Sign in to view

antonpirker added the New Integration Integrating with a new framework or library label Sep 11, 2025

Merge branch 'master' into patch-2

ab35ef8

antonpirker changed the title ~~integration for aiomysql~~ Feat(integrations): Add integration for aiomysql Sep 11, 2025

antonpirker changed the title ~~Feat(integrations): Add integration for aiomysql~~ feat(integrations): Add integration for aiomysql Sep 11, 2025

Merge branch 'master' into patch-2

c09eb44

This comment was marked as outdated.

Sign in to view

alexander-alderman-webb reviewed Oct 9, 2025

View reviewed changes

tonal added 3 commits October 10, 2025 15:49

Merge branch 'master' into patch-2

b3b04a1

Merge branch 'master' into patch-2

d9d7282

Merge branch 'getsentry:master' into patch-2

faf1a87

sentry Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

sentry Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py

cursor Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread scripts/split_tox_gh_actions/templates/test_group.jinja Outdated

Comment thread sentry_sdk/integrations/aiomysql.py

tonal and others added 3 commits April 13, 2026 11:25

Merge remote-tracking branch 'origin/patch-2' into patch-2

e25d3ad

# Conflicts: # .github/workflows/test-integrations-dbs.yml # sentry_sdk/integrations/aiomysql.py # tests/integrations/aiomysql/test_aiomysql.py

sentry Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed Apr 13, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

fix(aiomysql): Use public cursor.connection instead of private _conne…

a7319c9

…ction Fixes sentry bot review comment on PR getsentry#4703. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

tonal and others added 3 commits April 13, 2026 14:14

Merge branch 'master' into patch-2

facbe7b

sentry Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

tonal requested a review from alexander-alderman-webb April 16, 2026 03:58

Merge upstream/master into patch-2

a8e79d5

Resolve merge conflicts in auto-generated files (tox.ini, package_dependencies.jsonl, releases.jsonl, CI workflows) by taking upstream versions and regenerating with aiomysql config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

sentry Bot reviewed May 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

tonal and others added 2 commits May 12, 2026 15:52

Merge upstream/master into patch-2

93a0de6

Include fix for compromised transitive dependency (getsentry#6257). Regenerate tox.ini and CI workflows with aiomysql config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(aiomysql): Use record_sql_queries_supporting_streaming

81825b6

Replace record_sql_queries with record_sql_queries_supporting_streaming to support span streaming (addresses sentry bot review comment). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

sentry Bot reviewed May 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed May 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread tests/integrations/aiomysql/test_aiomysql.py

sentry Bot reviewed May 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

alexander-alderman-webb reviewed May 15, 2026

View reviewed changes

Conversation

tonal commented Aug 14, 2025 • edited by antonpirker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

antonpirker commented Sep 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

alexander-alderman-webb Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Integrations

Other

Bug Fixes 🐛

Anthropic

Pydantic Ai

Other

Internal Changes 🔧

Litellm

Other

Other

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonal commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonpirker commented Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonal commented May 12, 2026

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

alexander-alderman-webb May 15, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-alderman-webb May 15, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-alderman-webb commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

tonal commented Aug 14, 2025 •

edited by antonpirker

Loading

github-actions Bot commented Apr 12, 2026 •

edited

Loading

tonal commented Apr 13, 2026 •

edited

Loading

alexander-alderman-webb commented May 15, 2026 •

edited

Loading