test(browser-integration): Allow built-in 'now' frame in profile validation#21119
Open
github-actions[bot] wants to merge 1 commit into
Open
test(browser-integration): Allow built-in 'now' frame in profile validation#21119github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…h in profile validation Fixes #21114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Playwright test
traceLifecycleMode_overlapping-spanswas flaky becausevalidateProfilerequires every captured frame (other thanfetch/setTimeout/clearTimeout) to have anabs_path. When the JS Self Profiler samples while a built-in likeDate.now()/performance.now()is on the stack, the resulting frame is{ function: "now" }with no file location, causingexpect(frame).toHaveProperty('abs_path')to fail.Root cause
From the failing CI run:
nowis another browser built-in without a JS source location, the same shape as the already-allowlistedfetch/setTimeout/clearTimeout. This addsnowto the same allowlist.Fixes #21114