feat(deno): redis diagnostics channel based integration for deno#21087
Open
isaacs wants to merge 1 commit into
Open
feat(deno): redis diagnostics channel based integration for deno#21087isaacs wants to merge 1 commit into
isaacs wants to merge 1 commit into
Conversation
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
isaacs
added a commit
that referenced
this pull request
May 20, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
f176fd8 to
0fc320c
Compare
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
1048f32 to
72be1fa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
added a commit
that referenced
this pull request
May 21, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
11525d8 to
a8d3cb7
Compare
isaacs
added a commit
that referenced
this pull request
May 21, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
8226aaf to
5863e6c
Compare
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
5863e6c to
cd298fa
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd298fa. Configure here.
| const budget = SERIALIZATION_SUBSETS.find(({ regex }) => regex.test(cmdName))?.args ?? 0; | ||
| const argsToSerialize: Array<string | number | unknown[]> = ( | ||
| budget >= 0 ? cmdArgs.slice(0, budget) : cmdArgs.slice() | ||
| ).map(a => (a instanceof Uint8Array ? '<binary>' : a)); |
There was a problem hiding this comment.
Buffer args become binary placeholder
Medium Severity
The new defaultDbStatementSerializer maps every Uint8Array argument to the literal <binary> in db.statement. On Node, Buffer is a Uint8Array subclass, so command arguments that used to appear as readable keys now show as <binary> instead of decoded text, unlike the prior vendored serializer used by the removed node DC subscriber.
Reviewed by Cursor Bugbot for commit cd298fa. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns.
Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds
_sentrySpanonto the data in a RedisTracingChannelFactory which is passed to the core utility.