fix(solidstart): Use nitro module for build hooks to preserve preset hooks#20861
Merged
Conversation
…hooks Previously, to move the instrumentation file to the build output we added a `rollup:before` hook via nitro's `server.hooks`. This however overrides any nitro preset-defined hooks. Any preset that defines such a hook, has their hook not run. Notably, the `aws-preset` sets up `rollup:before` to switch the entry files when using aws streaming. The fix is to move our hook logic into our own nitro module, which then runs additvely on top of all the other hooks that have been defined by other presets. Closes: #20857
nicohrubec
approved these changes
May 13, 2026
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, to move the instrumentation file to the build output we added a
rollup:beforehook via nitro'sserver.hooks. This however overrides any nitro preset-defined hooks.Any preset that defines such a hook, has their hook not run. Notably, the
aws-presetsets uprollup:beforeto switch the entry files when using aws lambda streaming.The fix is to move our hook logic into our own nitro module, which then runs additvely on top of all the other hooks that have been defined by other presets.
Closes: #20857