Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 10.53.1

- fix(core): Don't gate user data for streamed spans at scope read time ([#20827](https://github.com/getsentry/sentry-javascript/pull/20827))
- fix(core): Include subpath type shims in published package ([#20835](https://github.com/getsentry/sentry-javascript/pull/20835))
- ref(hono): Consolidate route patching and add clarification comments ([#20829](https://github.com/getsentry/sentry-javascript/pull/20829))

<details>
<summary> <strong>Internal Changes</strong> </summary>

- chore(deps): Bump next from 15.5.15 to 15.5.18 in /dev-packages/e2e-tests/test-applications/nextjs-15-intl ([#20821](https://github.com/getsentry/sentry-javascript/pull/20821))

</details>

## 10.53.0

### Important Changes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@types/node": "^18.19.1",
"@types/react": "18.0.26",
"@types/react-dom": "18.0.9",
"next": "15.5.15",
"next": "15.5.18",
"next-intl": "^4.3.12",
"react": "latest",
"react-dom": "latest",
Expand Down
4 changes: 4 additions & 0 deletions packages/core/browser.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// This file is a compatibility shim for TypeScript compilers that do not
// support the package.json `exports` field for resolving subpath exports.
// Note: `typesVersions` in package.json may redirect this to the downleveled variant.
export * from './build/types/browser';
10 changes: 9 additions & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
"files": [
"/build",
"browser.js",
"server.js"
"browser.d.ts",
"server.js",
"server.d.ts"
],
"main": "build/cjs/index.js",
"module": "build/esm/index.js",
Expand Down Expand Up @@ -54,6 +56,12 @@
"<5.0": {
"build/types/index.d.ts": [
"build/types-ts3.8/index.d.ts"
],
"browser": [
"build/types-ts3.8/browser.d.ts"
],
"server": [
"build/types-ts3.8/server.d.ts"
]
}
},
Expand Down
4 changes: 4 additions & 0 deletions packages/core/server.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// This file is a compatibility shim for TypeScript compilers that do not
// support the package.json `exports` field for resolving subpath exports.
// Note: `typesVersions` in package.json may redirect this to the downleveled variant.
export * from './build/types/server';
8 changes: 4 additions & 4 deletions packages/core/src/semanticAttributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ export const SEMANTIC_ATTRIBUTE_SENTRY_SDK_NAME = 'sentry.sdk.name';
/** The version of the Sentry SDK */
export const SEMANTIC_ATTRIBUTE_SENTRY_SDK_VERSION = 'sentry.sdk.version';

/** The user ID (gated by sendDefaultPii) */
/** The user ID */
export const SEMANTIC_ATTRIBUTE_USER_ID = 'user.id';
/** The user email (gated by sendDefaultPii) */
/** The user email */
export const SEMANTIC_ATTRIBUTE_USER_EMAIL = 'user.email';
/** The user IP address (gated by sendDefaultPii) */
/** The user IP address */
export const SEMANTIC_ATTRIBUTE_USER_IP_ADDRESS = 'user.ip_address';
/** The user username (gated by sendDefaultPii) */
/** The user username */
export const SEMANTIC_ATTRIBUTE_USER_USERNAME = 'user.name';

/**
Expand Down
14 changes: 5 additions & 9 deletions packages/core/src/tracing/spans/captureSpan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function applyCommonSpanAttributes(
scopeData: ScopeData,
): void {
const sdk = client.getSdkMetadata();
const { release, environment, sendDefaultPii } = client.getOptions();
const { release, environment } = client.getOptions();

// avoid overwriting any previously set attributes (from users or potentially our SDK instrumentation)
safeSetSpanJSONAttributes(spanJSON, {
Expand All @@ -135,14 +135,10 @@ function applyCommonSpanAttributes(
[SEMANTIC_ATTRIBUTE_SENTRY_SEGMENT_ID]: serializedSegmentSpan.span_id,
[SEMANTIC_ATTRIBUTE_SENTRY_SDK_NAME]: sdk?.sdk?.name,
[SEMANTIC_ATTRIBUTE_SENTRY_SDK_VERSION]: sdk?.sdk?.version,
...(sendDefaultPii
? {
[SEMANTIC_ATTRIBUTE_USER_ID]: scopeData.user?.id,
[SEMANTIC_ATTRIBUTE_USER_EMAIL]: scopeData.user?.email,
[SEMANTIC_ATTRIBUTE_USER_IP_ADDRESS]: scopeData.user?.ip_address,
[SEMANTIC_ATTRIBUTE_USER_USERNAME]: scopeData.user?.username,
}
: {}),
[SEMANTIC_ATTRIBUTE_USER_ID]: scopeData.user?.id,
[SEMANTIC_ATTRIBUTE_USER_EMAIL]: scopeData.user?.email,
[SEMANTIC_ATTRIBUTE_USER_IP_ADDRESS]: scopeData.user?.ip_address,
[SEMANTIC_ATTRIBUTE_USER_USERNAME]: scopeData.user?.username,
...scopeData.attributes,
});
}
Expand Down
Loading
Loading