Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22, 24]
node: [18, 20, 22, 24, 26]
steps:
- name: Check out base commit (${{ github.event.pull_request.base.sha }})
uses: actions/checkout@v6
Expand Down Expand Up @@ -810,7 +810,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22, 24]
node: [18, 20, 22, 24, 26]
typescript:
- false
include:
Expand Down Expand Up @@ -851,7 +851,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22, 24]
node: [18, 20, 22, 24, 26]
typescript:
- false
include:
Expand Down Expand Up @@ -939,7 +939,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22, 24]
node: [18, 20, 22, 24, 26]
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v6
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { Event } from '@sentry/core';
import { afterAll, describe, expect, test } from 'vitest';
import { conditionalTest } from '../../utils';
import { cleanupChildProcesses, createRunner } from '../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../utils/node-deprecation-breadcrumbs';

const WORKER_EVENT: Event = {
exception: {
Expand Down Expand Up @@ -31,6 +32,7 @@ const CHILD_EVENT: Event = {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
category: 'child_process',
message: "Child process exited with code '1'",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { conditionalTest } from '../../../../utils';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing fetch', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -14,6 +15,7 @@ describe('outgoing fetch', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing fetch with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -23,6 +24,7 @@ describe('outgoing fetch with tracePropagation disabled', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -12,6 +13,7 @@ describe('outgoing http', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -23,6 +24,7 @@ describe('outgoing http with tracePropagation disabled', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http requests with tracing & spans disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand Down Expand Up @@ -41,6 +42,7 @@ describe('outgoing http requests with tracing & spans disabled', () => {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { conditionalTest } from '../../../../utils';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand Down Expand Up @@ -43,6 +44,7 @@ describe('outgoing http', () => {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import type { Breadcrumb } from '@sentry/core';
import { NODE_VERSION } from '@sentry/node-core';
import { expect } from 'vitest';

export function getNodeDeprecationBreadcrumbs(): Breadcrumb[] {
const message = `(node:4075) [DEP0205] DeprecationWarning: \`module.register()\` is deprecated. Use \`module.registerHooks()\` instead.
(Use \`node --trace-deprecation ...\` to show where the warning was created)`;

if (NODE_VERSION.major < 26) {
return [];
}

return [
{
category: 'console',
data: {
arguments: [message],
logger: 'console',
},
level: 'error',
message: message,
timestamp: expect.any(Number),
},
];
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { Event } from '@sentry/core';
import { afterAll, describe, expect, test } from 'vitest';
import { conditionalTest } from '../../utils';
import { cleanupChildProcesses, createRunner } from '../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../utils/node-deprecation-breadcrumbs';

const WORKER_EVENT: Event = {
exception: {
Expand Down Expand Up @@ -31,6 +32,7 @@ const CHILD_EVENT: Event = {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
category: 'child_process',
message: "Child process exited with code '1'",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing fetch', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -12,6 +13,7 @@ describe('outgoing fetch', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing fetch with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -23,6 +24,7 @@ describe('outgoing fetch with tracePropagation disabled', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -12,6 +13,7 @@ describe('outgoing http', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http with tracePropagation disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand All @@ -23,6 +24,7 @@ describe('outgoing http with tracePropagation disabled', () => {
.expect({
event: {
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http requests with tracing & spans disabled', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand Down Expand Up @@ -41,6 +42,7 @@ describe('outgoing http requests with tracing & spans disabled', () => {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';
import { getNodeDeprecationBreadcrumbs } from '../../../../utils/node-deprecation-breadcrumbs';

describe('outgoing http', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
Expand Down Expand Up @@ -41,6 +42,7 @@ describe('outgoing http', () => {
],
},
breadcrumbs: [
...getNodeDeprecationBreadcrumbs(),
{
message: 'manual breadcrumb',
timestamp: expect.any(Number),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import type { Breadcrumb } from '@sentry/core';
import { NODE_VERSION } from '.';
import { expect } from 'vitest';

export function getNodeDeprecationBreadcrumbs(): Breadcrumb[] {
const message = `(node:4075) [DEP0205] DeprecationWarning: \`module.register()\` is deprecated. Use \`module.registerHooks()\` instead.
(Use \`node --trace-deprecation ...\` to show where the warning was created)`;

if (NODE_VERSION < 26) {
return [];
}

return [
{
category: 'console',
data: {
arguments: [message],
logger: 'console',
},
level: 'error',
message: message,
timestamp: expect.any(Number),
},
];
}
2 changes: 1 addition & 1 deletion packages/profiling-node/src/integration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ class ContinuousProfiler {

/** Exported only for tests. */
export const _nodeProfilingIntegration = ((): ProfilingIntegration<NodeClient> => {
if (![16, 18, 20, 22, 24].includes(NODE_MAJOR)) {
if (![16, 18, 20, 22, 24, 26].includes(NODE_MAJOR)) {
consoleSandbox(() => {
// eslint-disable-next-line no-console
console.warn(
Expand Down
Loading