Remove testBuildType mechanism from UI test modules#5388
Open
runningcode wants to merge 2 commits intomainfrom
Open
Remove testBuildType mechanism from UI test modules#5388runningcode wants to merge 2 commits intomainfrom
runningcode wants to merge 2 commits intomainfrom
Conversation
The debug and release build types were configured identically in both uitest modules (same minification, proguard rules, signing). Disable the debug variant unconditionally, hardcode testBuildType to release, and combine the now-simplified Gradle invocations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5865051 | 319.74 ms | 365.60 ms | 45.86 ms |
| 0220a5c | 452.20 ms | 479.33 ms | 27.12 ms |
| 2124a46 | 319.19 ms | 415.04 ms | 95.85 ms |
| 2195398 | 322.52 ms | 361.91 ms | 39.39 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| d364ace | 382.77 ms | 443.21 ms | 60.44 ms |
| d15471f | 379.40 ms | 470.76 ms | 91.36 ms |
| 9139b91 | 351.35 ms | 355.63 ms | 4.28 ms |
| fc5ccaf | 322.49 ms | 405.25 ms | 82.76 ms |
| 52feca7 | 314.77 ms | 378.67 ms | 63.90 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5865051 | 0 B | 0 B | 0 B |
| 0220a5c | 0 B | 0 B | 0 B |
| 2124a46 | 1.58 MiB | 2.12 MiB | 551.51 KiB |
| 2195398 | 0 B | 0 B | 0 B |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 9139b91 | 1.58 MiB | 2.13 MiB | 559.52 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| 52feca7 | 0 B | 0 B | 0 B |
0xadam-brown
approved these changes
May 8, 2026
Member
0xadam-brown
left a comment
There was a problem hiding this comment.
Claude tells me:
The debug and release build types in this PR's two uitest modules were configured identically (same minification, same proguard rules, same signing config), and every
single call site always passed -DtestBuildType=release to override the default. The System.getProperty("testBuildType", "debug") mechanism gave the appearance of a configurable choice, but in practice nobody ever used it as "debug" — it was dead flexibility.The PR removes that indirection so the build config matches how it was actually used.
Good deal 👍
Contributor
Author
|
Yup that's correct. In addition, it also increases build times and cache sizes because if you switch variants then you have to rebuild it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry-uitest-androidandsentry-uitest-android-benchmarksince debug and release were configured identically (same minification, proguard rules, signing)testBuildType = "release"and remove the-DtestBuildType=releasesystem property mechanism#skip-changelog
🤖 Generated with Claude Code