Skip to content

Remove testBuildType mechanism from UI test modules#5388

Open
runningcode wants to merge 2 commits intomainfrom
no/remove-test-build-type
Open

Remove testBuildType mechanism from UI test modules#5388
runningcode wants to merge 2 commits intomainfrom
no/remove-test-build-type

Conversation

@runningcode
Copy link
Copy Markdown
Contributor

@runningcode runningcode commented May 8, 2026

Summary

  • Disable the debug variant unconditionally in sentry-uitest-android and sentry-uitest-android-benchmark since debug and release were configured identically (same minification, proguard rules, signing)
  • Hardcode testBuildType = "release" and remove the -DtestBuildType=release system property mechanism
  • Combine separate Gradle invocations into single commands in the Makefile and docs

#skip-changelog

🤖 Generated with Claude Code

runningcode and others added 2 commits May 8, 2026 10:58
The debug and release build types were configured identically in
both uitest modules (same minification, proguard rules, signing).
Disable the debug variant unconditionally, hardcode testBuildType
to release, and combine the now-simplified Gradle invocations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sentry
Copy link
Copy Markdown

sentry Bot commented May 8, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.41.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 307.98 ms 327.92 ms 19.94 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5865051 319.74 ms 365.60 ms 45.86 ms
0220a5c 452.20 ms 479.33 ms 27.12 ms
2124a46 319.19 ms 415.04 ms 95.85 ms
2195398 322.52 ms 361.91 ms 39.39 ms
bbc35bb 298.53 ms 372.17 ms 73.64 ms
d364ace 382.77 ms 443.21 ms 60.44 ms
d15471f 379.40 ms 470.76 ms 91.36 ms
9139b91 351.35 ms 355.63 ms 4.28 ms
fc5ccaf 322.49 ms 405.25 ms 82.76 ms
52feca7 314.77 ms 378.67 ms 63.90 ms

App size

Revision Plain With Sentry Diff
5865051 0 B 0 B 0 B
0220a5c 0 B 0 B 0 B
2124a46 1.58 MiB 2.12 MiB 551.51 KiB
2195398 0 B 0 B 0 B
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
9139b91 1.58 MiB 2.13 MiB 559.52 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
52feca7 0 B 0 B 0 B

@runningcode runningcode marked this pull request as ready for review May 8, 2026 09:19
Copy link
Copy Markdown
Member

@0xadam-brown 0xadam-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude tells me:

The debug and release build types in this PR's two uitest modules were configured identically (same minification, same proguard rules, same signing config), and every
single call site always passed -DtestBuildType=release to override the default. The System.getProperty("testBuildType", "debug") mechanism gave the appearance of a configurable choice, but in practice nobody ever used it as "debug" — it was dead flexibility.

The PR removes that indirection so the build config matches how it was actually used.

Good deal 👍

@runningcode
Copy link
Copy Markdown
Contributor Author

Yup that's correct. In addition, it also increases build times and cache sizes because if you switch variants then you have to rebuild it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants