Skip to content

chore(deps): update Native SDK to v0.13.9#5362

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
deps/scripts/update-sentry-native-ndk.sh
Closed

chore(deps): update Native SDK to v0.13.9#5362
github-actions[bot] wants to merge 1 commit intomainfrom
deps/scripts/update-sentry-native-ndk.sh

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 4, 2026

Bumps scripts/update-sentry-native-ndk.sh from 0.13.8 to 0.13.9.

Auto-generated by a dependency updater.

Changelog

0.13.9

Features:

  • Enable structured logs by default; logs are now opt-out via sentry_options_set_enable_logs(options, false). (#1673)
  • Crashpad: add macOS support for the crashpad_wait_for_upload flag. (#1679, crashpad#152)
  • Add experimental support for large attachment uploads, opt-in via sentry_options_set_enable_large_attachments. (#1545)

Fixes:

  • Fix event ownership (potential double-decref) in sentry_capture_minidump. (#1669)
  • Guard against internal stringbuilder append and reserve size overflows. (#1672)
  • Preserve attachments added during crash handling (#1687)
  • Fix build-time warnings with C++ builds. (#1671)
  • Native: respect the shutdown_timeout option in the daemon. (#1691)

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 4, 2026
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-sentry-native-ndk.sh branch from e18916f to 6848c11 Compare May 4, 2026 09:39
@sentry
Copy link
Copy Markdown

sentry Bot commented May 4, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.40.0 (1) release

⚙️ sentry-android Build Distribution Settings

Comment thread gradle/libs.versions.toml
retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" }
retrofit-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit" }
sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.13.8" }
sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.13.9" }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Bumping sentry-native-ndk enables native structured logs by default. The Java SDK does not propagate its options.getLogs().isEnabled() setting, causing unintended log collection.
Severity: MEDIUM

Suggested Fix

In SentryNdk.java, when constructing NdkOptions, read the value from options.getLogs().isEnabled() and pass it to the native layer. This likely involves calling a setter on NdkOptions, such as sentry_options_set_enable_logs(options, enabled), to ensure the Java SDK's configuration is respected by the native SDK.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: gradle/libs.versions.toml#L154

Potential issue: The update to `sentry-native-ndk` version `0.13.9` changes the default
behavior to enable native structured logs. The Java-to-native bridge in `SentryNdk.java`
does not pass the Java SDK's logging configuration (`options.getLogs().isEnabled()`,
which defaults to `false`) to the native layer's `NdkOptions`. As a result, for
applications using native code that calls Sentry's structured logging APIs, logs will be
sent to Sentry by default, even when the developer has not opted in via the Java SDK
options. This contradicts the Java SDK's default-off behavior for logging.

Did we get this right? 👍 / 👎 to inform future reviews.

@romtsn romtsn closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants