chore(deps): update Native SDK to v0.13.9#5362
Closed
github-actions[bot] wants to merge 1 commit intomainfrom
Closed
chore(deps): update Native SDK to v0.13.9#5362github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
e18916f to
6848c11
Compare
📲 Install BuildsAndroid
|
| retrofit = { module = "com.squareup.retrofit2:retrofit", version.ref = "retrofit" } | ||
| retrofit-gson = { module = "com.squareup.retrofit2:converter-gson", version.ref = "retrofit" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.13.8" } | ||
| sentry-native-ndk = { module = "io.sentry:sentry-native-ndk", version = "0.13.9" } |
There was a problem hiding this comment.
Bug: Bumping sentry-native-ndk enables native structured logs by default. The Java SDK does not propagate its options.getLogs().isEnabled() setting, causing unintended log collection.
Severity: MEDIUM
Suggested Fix
In SentryNdk.java, when constructing NdkOptions, read the value from options.getLogs().isEnabled() and pass it to the native layer. This likely involves calling a setter on NdkOptions, such as sentry_options_set_enable_logs(options, enabled), to ensure the Java SDK's configuration is respected by the native SDK.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: gradle/libs.versions.toml#L154
Potential issue: The update to `sentry-native-ndk` version `0.13.9` changes the default
behavior to enable native structured logs. The Java-to-native bridge in `SentryNdk.java`
does not pass the Java SDK's logging configuration (`options.getLogs().isEnabled()`,
which defaults to `false`) to the native layer's `NdkOptions`. As a result, for
applications using native code that calls Sentry's structured logging APIs, logs will be
sent to Sentry by default, even when the developer has not opted in via the Java SDK
options. This contradicts the Java SDK's default-off behavior for logging.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-sentry-native-ndk.sh from 0.13.8 to 0.13.9.
Auto-generated by a dependency updater.
Changelog
0.13.9
Features:
sentry_options_set_enable_logs(options, false). (#1673)crashpad_wait_for_uploadflag. (#1679, crashpad#152)sentry_options_set_enable_large_attachments. (#1545)Fixes:
shutdown_timeoutoption in the daemon. (#1691)