docs(react-native): document release/dist env vars#124
Open
zerone0x wants to merge 1 commit intogetsentry:mainfrom
Open
docs(react-native): document release/dist env vars#124zerone0x wants to merge 1 commit intogetsentry:mainfrom
zerone0x wants to merge 1 commit intogetsentry:mainfrom
Conversation
Co-Authored-By: GPT-5.5 <noreply@nousresearch.com>
Comment on lines
+674
to
+676
| ``` | ||
|
|
||
| `SENTRY_RELEASE` and `SENTRY_DIST` are read during the native build. They do not need to be bundled into the app at runtime. |
There was a problem hiding this comment.
Bug: The documentation for SENTRY_RELEASE and SENTRY_DIST is contradictory, stating they are only for native build time while also being listed as runtime SDK initialization options.
Severity: MEDIUM
Suggested Fix
Revert the new documentation to align with the previous version and other Sentry SDKs. The text should clarify that SENTRY_RELEASE and SENTRY_DIST are used as fallbacks for the options.release and options.dist SDK initialization options, and must be available during the Metro bundling process to be included in the final app bundle.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-react-native-sdk/SKILL.md#L674-L676
Potential issue: The documentation added at lines 661-676 incorrectly states that the
`SENTRY_RELEASE` and `SENTRY_DIST` environment variables are only used at native build
time and "do not need to be bundled into the app at runtime." This contradicts other
sections of the same document (lines 554-555) and the official Sentry React Native
documentation, which clarify these are read automatically during SDK initialization.
This misleading guidance will cause AI models to advise developers against setting these
variables during the bundling process, resulting in Sentry events missing release and
distribution information, which will break source map processing.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SENTRY_RELEASEandSENTRY_DISTenvironment variables.env/ CI exampleFixes #123
Tests
git diff --checkscripts/build-skill-tree.sh --check