fix(attributes): Increase some PII values#373
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| "brief": "The URL of the resource that was fetched.", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| "key": "true" | ||
| }, | ||
| "is_in_otel": true, | ||
| "example": "https://example.com/test?foo=bar#buzz", |
There was a problem hiding this comment.
Bug: Updating the PII classification for a canonical attribute like url.full does not propagate the change to its deprecated alias, http.url.
Severity: MEDIUM
Suggested Fix
Modify the attribute update process to ensure that any changes to a canonical attribute's metadata, such as PII classification, are automatically propagated to all of its deprecated aliases. This will maintain data handling consistency.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: model/attributes/url/url__full.json#L3-L9
Potential issue: Updating the PII classification of a canonical attribute does not
propagate the change to its deprecated alias. For instance, the change classifies
`url.full` as PII `true`, but its alias `http.url` remains `maybe`. Similarly,
`gen_ai.response.streaming` is updated to `maybe`, while its alias `ai.streaming`
remains `false`. This inconsistency means the same data is treated differently for PII
depending on the attribute name used, which could lead to incorrect data handling.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f927b6. Configure here.

Description
thread.idandgen_ai.response.streamingshould be excluded from PII.http.query,url.query, andurl.fullshould be considered sensitive by default.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.Closes INGEST-918.