Skip to content

fix(attributes): Increase some PII values#373

Merged
loewenheim merged 3 commits into
mainfrom
sebastian/pii
May 13, 2026
Merged

fix(attributes): Increase some PII values#373
loewenheim merged 3 commits into
mainfrom
sebastian/pii

Conversation

@loewenheim
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim commented May 13, 2026

Description

  • There is no good reason thread.id and gen_ai.response.streaming should be excluded from PII.
  • http.query, url.query, and url.full should be considered sensitive by default.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

Closes INGEST-918.

@loewenheim loewenheim requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners May 13, 2026 11:37
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 13, 2026

INGEST-918

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add calculated performance scores by loewenheim in #355
  • Add rpc.response.status_code attribute by alexander-alderman-webb in #352
  • Add rpc.method attribute by alexander-alderman-webb in #351
  • Add app vitals start attributes by buenaflor in #353
  • Add process.runtime.engine.* attributes by chargome in #347

Bug Fixes 🐛

Attributes

  • Increase some PII values by loewenheim in #373
  • Change several deprecation statuses to normalize to align with ingestion paths by constantinius in #350

Other

  • (create) Replace angle brackets in file names by loewenheim in #356

Internal Changes 🔧

  • (gh) Remove myself from CODEOWNERS by lcian in #354
  • Bump vulnerable js packages by chargome in #359

🤖 This preview updates automatically when you update the PR.

Comment on lines 3 to 9
"brief": "The URL of the resource that was fetched.",
"type": "string",
"pii": {
"key": "maybe"
"key": "true"
},
"is_in_otel": true,
"example": "https://example.com/test?foo=bar#buzz",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating the PII classification for a canonical attribute like url.full does not propagate the change to its deprecated alias, http.url.
Severity: MEDIUM

Suggested Fix

Modify the attribute update process to ensure that any changes to a canonical attribute's metadata, such as PII classification, are automatically propagated to all of its deprecated aliases. This will maintain data handling consistency.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: model/attributes/url/url__full.json#L3-L9

Potential issue: Updating the PII classification of a canonical attribute does not
propagate the change to its deprecated alias. For instance, the change classifies
`url.full` as PII `true`, but its alias `http.url` remains `maybe`. Similarly,
`gen_ai.response.streaming` is updated to `maybe`, while its alias `ai.streaming`
remains `false`. This inconsistency means the same data is treated differently for PII
depending on the attribute name used, which could lead to incorrect data handling.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8f927b6. Configure here.

Comment thread javascript/sentry-conventions/src/attributes.ts
@loewenheim loewenheim merged commit 523f1f0 into main May 13, 2026
11 checks passed
@loewenheim loewenheim deleted the sebastian/pii branch May 13, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants