Skip to content

feat(preprod): Increase connect timeout, display full errors#3204

Merged
lcian merged 2 commits intomasterfrom
feat/snapshots-upload-improvements
Mar 11, 2026
Merged

feat(preprod): Increase connect timeout, display full errors#3204
lcian merged 2 commits intomasterfrom
feat/snapshots-upload-improvements

Conversation

@lcian
Copy link
Member

@lcian lcian commented Mar 11, 2026

We've been running the snapshots command in sentry's CI for some time and observed some failures.
Example: https://github.com/getsentry/sentry/actions/runs/22928756345/job/66545427887?pr=109531

This addresses that by making 2 changes:

  • Improves error reporting by wrapping upload errors with anyhow::Error and using alternate formatting ({:#}) to display the full error chain. Before, you would just see error sending request for url and nothing more.
    (it would also be possible to print it manually iterating sources, it's just easier to wrap it in anyhow)

  • Sets the connect timeout on objectstore_client's underling reqwest::Client to a very generous 10s.
    We were most likely running into that timeout, which objectstore_client sets to 0.1s by default. That's suitable for internal services communicating directly with objectstore in the same VPC, but probably too low for an environment like GH actions.

There's no concrete motivation for choosing specifically 10s, we just need to choose something higher than 0.1s.
I checked what we do for curl (used for all other requests) and it seems we don't set any kind of timeout on it.

#skip-changelog as we've been skipping changelog for this command, as it's still experimental and used only for internal testing.

…hot uploads

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

This comment was marked as resolved.

@lcian lcian changed the title fix(preprod): Add connect timeout and improve error display for snapshot uploads feat(preprod): Increase connect timeout, display full errors Mar 11, 2026
@lcian lcian marked this pull request as ready for review March 11, 2026 11:40
@lcian lcian requested review from a team as code owners March 11, 2026 11:40
@lcian lcian merged commit c133c5e into master Mar 11, 2026
25 checks passed
@lcian lcian deleted the feat/snapshots-upload-improvements branch March 11, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants