Skip to content

feat: add per-dependency health timeout#310

Draft
joshuarli wants to merge 1 commit intomainfrom
feat-per-container-timeouts
Draft

feat: add per-dependency health timeout#310
joshuarli wants to merge 1 commit intomainfrom
feat-per-container-timeouts

Conversation

@joshuarli
Copy link
Copy Markdown
Member

https://github.com/getsentry/getsentry/actions/runs/24588958799/job/71905342812#step:12:97
this says Container kafka did not become healthy within 120 seconds. but kafka ended up being healthy right after - not sure why but let's increase the default timeout to 180s

also while we're here - let's add per-dependency timeouts


Adds per-dependency healthcheck_timeout configuration to devservices by
moving the timeout field from ServiceConfig down to Dependency, threading
it through a new ContainerHealthcheckConfig type (replacing
ContainerNames) so each container's wait_for_healthy call uses its own
configured value. Each dependency now prints its timeout when waiting
(Waiting for kafka to be healthy (timeout: 300s)). Defaults to 180s (up
from 120s). Known limitation tracked in TODO.md: remote sub-service
containers (e.g. kafka inside snuba) cannot yet be individually configured
from the calling service's config.

@github-actions
Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (cli) Add --config option for custom config file path by hubertdeng123 in #307
  • Add per-dependency health timeout by joshuarli in #310
  • Pytest 9, xdist, python 3.13.1 by joshuarli in #309
  • Timestamps and health logs by joshuarli in #308
  • Uv by joshuarli in #305

Bug Fixes 🐛

  • (state) Gracefully handle stale service entries in state database by vaind in #302

Internal Changes 🔧

Release

  • Fix changelog-preview permissions by BYK in #300
  • Switch from action-prepare-release to Craft by BYK in #299

Other

  • (deps-dev) Bump setuptools from 70.0.0 to 78.1.1 by dependabot in #294
  • Pin GitHub Actions to full-length commit SHAs by joshuarli in #306

🤖 This preview updates automatically when you update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant