Skip to content

Drop legacy document columns and approver tables#1019

Merged
SachaProbo merged 1 commit intomainfrom
SachaProbo/document-migration-todos
Apr 13, 2026
Merged

Drop legacy document columns and approver tables#1019
SachaProbo merged 1 commit intomainfrom
SachaProbo/document-migration-todos

Conversation

@SachaProbo
Copy link
Copy Markdown
Contributor

@SachaProbo SachaProbo commented Apr 9, 2026

The title, classification, and document_type columns have been moved to document_versions. The document_approvers and document_version_approvers tables have been replaced by approval quorums and decisions.


Summary by cubic

Drops legacy document columns (title, classification, document_type) from documents and removes old approver tables in favor of approval quorums/decisions. This completes the move of document metadata to document_versions and simplifies the approvals schema.

  • Migration
    • Run migration 20260409T130000Z.sql to drop documents.title, documents.classification, documents.document_type, document_approvers, and document_version_approvers.
    • Read metadata from document_versions and use approval quorums/decisions for approvals.

Written for commit eeee93e. Summary will update on new commits.

@SachaProbo SachaProbo requested review from a team and gearnode and removed request for gearnode April 9, 2026 18:18
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Copy link
Copy Markdown
Contributor

@gearnode gearnode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The title, classification, and document_type columns have been moved to
document_versions. The document_approvers and document_version_approvers
tables have been replaced by approval quorums and decisions.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
@SachaProbo SachaProbo force-pushed the SachaProbo/document-migration-todos branch from c959fbf to eeee93e Compare April 13, 2026 16:10
Copy link
Copy Markdown
Contributor

@gearnode gearnode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SachaProbo SachaProbo merged commit eeee93e into main Apr 13, 2026
22 of 26 checks passed
@SachaProbo SachaProbo deleted the SachaProbo/document-migration-todos branch April 13, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants