Replace exception-only retry policy with Result-aware retry logic#7
Draft
Copilot wants to merge 3 commits intoromantic-meninskyfrom
Draft
Replace exception-only retry policy with Result-aware retry logic#7Copilot wants to merge 3 commits intoromantic-meninskyfrom
Copilot wants to merge 3 commits intoromantic-meninskyfrom
Conversation
Co-authored-by: nibblesnbits <6042917+nibblesnbits@users.noreply.github.com>
Co-authored-by: nibblesnbits <6042917+nibblesnbits@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve retry logic using Result type
Replace exception-only retry policy with Result-aware retry logic
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webhook handlers wrap errors in
Result<,>types rather than throwing exceptions. The existing retry policy only caught exceptions, so retries never triggered when handlers returned wrapped errors.Changes
Upgraded to Polly v8 ResiliencePipeline with result-based retry logic:
IStatusCodeHttpResultwith 5xx status codes (transient failures)Added observability:
Implementation
Handlers catch and wrap permanent failures → return 400 → no retry
Handlers catch and wrap transient failures → return 500 → retry
Uncaught exceptions are infrastructure failures → retry
Original prompt
Created from VS Code via the GitHub Pull Request extension.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.