Skip to content

boost src/ offloading #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 1 commit into from
Apr 4, 2026
+284 −107
Merged

boost src/ offloading #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,9 @@ if (REFLECTCPP_YAML OR REFLECTCPP_CHECK_HEADERS)
endif ()

if (REFLECTCPP_BOOST_SERIALIZATION OR REFLECTCPP_CHECK_HEADERS)
list(APPEND REFLECT_CPP_SOURCES
src/reflectcpp_boost_serialization.cpp
)
if (NOT TARGET Boost::serialization)
find_package(Boost REQUIRED COMPONENTS serialization)
endif ()
Expand Down
149 changes: 42 additions & 107 deletions include/rfl/boost_serialization/Writer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,28 +30,19 @@ class Writer {
using OutputUnionType = BoostOutputUnion;
using OutputVarType = BoostOutputVar;

Writer(OArchive* _ar) : ar_(_ar) {}
Writer(OArchive* _ar);

~Writer() = default;

OutputArrayType array_as_root(const size_t _size) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputArrayType{};
}
OutputArrayType array_as_root(const size_t _size) const;
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Moving the implementation of these methods to a .cpp file and using explicit instantiation restricts the Writer class to only the archive types explicitly handled by the library. This is a breaking change for users of other Boost archive types, such as xml_oarchive or custom archives, as they will now encounter linker errors for these non-template methods. To maintain support for arbitrary archives while still improving compile times, consider moving the implementations to a separate header file (e.g., Writer.tcc) and including it at the end of this header, or keep the implementations inline.


OutputMapType map_as_root(const size_t _size) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputMapType{};
}
OutputMapType map_as_root(const size_t _size) const;

OutputObjectType object_as_root(const size_t _size) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputObjectType{};
}
OutputObjectType object_as_root(const size_t _size) const;

OutputVarType null_as_root() const { return OutputVarType{}; }
OutputVarType null_as_root() const;

OutputUnionType union_as_root() const { return OutputUnionType{}; }
OutputUnionType union_as_root() const;

template <class T>
OutputVarType value_as_root(const T& _var) const {
Expand All @@ -60,109 +51,57 @@ class Writer {
}

OutputArrayType add_array_to_array(const size_t _size,
OutputArrayType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputArrayType{};
}
OutputArrayType* _parent) const;

OutputArrayType add_array_to_map(const std::string_view& _name,
const size_t _size,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputArrayType{};
}
OutputMapType* _parent) const;

OutputArrayType add_array_to_object(const std::string_view& /*_name*/,
OutputArrayType add_array_to_object(const std::string_view& _name,
const size_t _size,
OutputObjectType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputArrayType{};
}
OutputObjectType* _parent) const;

OutputArrayType add_array_to_union(const size_t _index, const size_t _size,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputArrayType{};
}
OutputUnionType* _parent) const;

OutputMapType add_map_to_array(const size_t _size,
OutputArrayType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputMapType{};
}
OutputArrayType* _parent) const;

OutputMapType add_map_to_map(const std::string_view& _name,
const size_t _size,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputMapType{};
}
OutputMapType* _parent) const;

OutputMapType add_map_to_object(const std::string_view& /*_name*/,
OutputMapType add_map_to_object(const std::string_view& _name,
const size_t _size,
OutputObjectType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputMapType{};
}
OutputObjectType* _parent) const;

OutputMapType add_map_to_union(const size_t _index, const size_t _size,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputMapType{};
}
OutputUnionType* _parent) const;

OutputObjectType add_object_to_array(const size_t _size,
OutputArrayType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputObjectType{};
}
OutputArrayType* _parent) const;

OutputObjectType add_object_to_map(const std::string_view& _name,
const size_t _size,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputObjectType{};
}
OutputMapType* _parent) const;

OutputObjectType add_object_to_object(const std::string_view& /*_name*/,
OutputObjectType add_object_to_object(const std::string_view& _name,
const size_t _size,
OutputObjectType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_size);
return OutputObjectType{};
}
OutputObjectType* _parent) const;

OutputObjectType add_object_to_union(const size_t _index, const size_t _size,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
*ar_ << static_cast<std::uint64_t>(_size);
return OutputObjectType{};
}
OutputUnionType* _parent) const;

OutputUnionType add_union_to_array(OutputArrayType* /*_parent*/) const {
return OutputUnionType{};
}
OutputUnionType add_union_to_array(OutputArrayType* _parent) const;

OutputUnionType add_union_to_map(const std::string_view& _name,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
return OutputUnionType{};
}
OutputMapType* _parent) const;

OutputUnionType add_union_to_object(const std::string_view& /*_name*/,
OutputObjectType* /*_parent*/) const {
return OutputUnionType{};
}
OutputUnionType add_union_to_object(const std::string_view& _name,
OutputObjectType* _parent) const;

OutputUnionType add_union_to_union(const size_t _index,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
return OutputUnionType{};
}
OutputUnionType* _parent) const;

template <class T>
OutputVarType add_value_to_array(const T& _var,
Expand All @@ -174,7 +113,7 @@ class Writer {
template <class T>
OutputVarType add_value_to_map(const std::string_view& _name, const T& _var,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
write_key(_name);
new_value(_var);
return OutputVarType{};
}
Expand All @@ -190,39 +129,35 @@ class Writer {
template <class T>
OutputVarType add_value_to_union(const size_t _index, const T& _var,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
write_index(_index);
new_value(_var);
return OutputVarType{};
}

OutputVarType add_null_to_array(OutputArrayType* /*_parent*/) const {
return OutputVarType{};
}
OutputVarType add_null_to_array(OutputArrayType* _parent) const;

OutputVarType add_null_to_map(const std::string_view& _name,
OutputMapType* /*_parent*/) const {
*ar_ << std::string(_name);
return OutputVarType{};
}
OutputMapType* _parent) const;

OutputVarType add_null_to_object(const std::string_view& /*_name*/,
OutputObjectType* /*_parent*/) const {
return OutputVarType{};
}
OutputVarType add_null_to_object(const std::string_view& _name,
OutputObjectType* _parent) const;

OutputVarType add_null_to_union(const size_t _index,
OutputUnionType* /*_parent*/) const {
*ar_ << static_cast<std::uint64_t>(_index);
return OutputVarType{};
}
OutputUnionType* _parent) const;

void end_array(OutputArrayType* /*_arr*/) const {}
void end_array(OutputArrayType* _arr) const;

void end_map(OutputMapType* /*_obj*/) const {}
void end_map(OutputMapType* _obj) const;

void end_object(OutputObjectType* /*_obj*/) const {}
void end_object(OutputObjectType* _obj) const;

private:
void write_size(const size_t _size) const;

void write_index(const size_t _index) const;

void write_key(const std::string_view& _name) const;

template <class T>
void new_value(const T& _var) const {
using Type = std::remove_cvref_t<T>;
Expand Down
1 change: 1 addition & 0 deletions src/reflectcpp_boost_serialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
#include "rfl/boost_serialization/Writer.cpp"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Including a .cpp file is generally discouraged as it can lead to multiple definition errors if the included file is also compiled as a separate translation unit. It also violates common naming conventions for implementation files intended for inclusion. Consider renaming src/rfl/boost_serialization/Writer.cpp to a more appropriate extension like .tcc or .ipp, or moving the code directly into this file.

Loading
Loading