Make sure that flag enums with value zero are correctly serialized; fixes #640#644
Merged
liuzicheng1987 merged 1 commit intomainfrom Apr 3, 2026
Merged
Make sure that flag enums with value zero are correctly serialized; fixes #640#644liuzicheng1987 merged 1 commit intomainfrom
liuzicheng1987 merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves the serialization of bitflag enums by handling cases where no flags are set and adds a corresponding test case. The review feedback suggests using the to_string_or_number helper instead of a hardcoded "0" to ensure that named constants for zero values (e.g., None = 0) are correctly serialized, along with a corresponding update to the test expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.