[feat]: DOM proxy for slot() structural changes#27
Closed
arielsalminen wants to merge 2 commits intofeature/slottablefrom
Closed
[feat]: DOM proxy for slot() structural changes#27arielsalminen wants to merge 2 commits intofeature/slottablefrom
slot() structural changes#27arielsalminen wants to merge 2 commits intofeature/slottablefrom
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is more of a POC and won’t make it to the official releases as such, but it adds DOM method proxying to the
slot()introduced in #26. This allows JS frameworks to also add, remove and reorder children with Light DOM Primitive Components after projection, not just update values.The PR itself adds a transparent proxy layer that intercepts
insertBefore,appendChild,removeChildandtextContenton the host element and redirects them to the innerthis.element.Related to #9, #10, #24 and #26