Fix typecheck failure in example/convex/setup.test.ts

[sethconvex]

Summary

Restores npm run typecheck to green. Main has been failing on every push since 2026-04-01, masking real type regressions in subsequent PRs.

Root cause

Commit e29f2bb ("better convex test types") made @convex-dev/agent's register signature generic. Sibling components didn't all follow:

Package	Pinned here	Latest	Generic register?
@convex-dev/agent	this repo	—	✅
@convex-dev/workflow	0.3.6	0.3.12	✅ in 0.3.12
@convex-dev/workpool	0.3.1 (transitive)	0.4.6	✅ in 0.4.x
@convex-dev/rate-limiter	0.3.2	0.3.2 (latest)	❌ still non-generic

TestConvex is invariant in its schema parameter (it appears in both contravariant input positions like t.query(...) args and covariant return positions), so a TestConvex<SchemaDefinition<{ rawUsage: ..., invoices: ... }>> is not assignable to TestConvex<SchemaDefinition<GenericSchema, boolean>> even though the value is structurally compatible.

Fix

• Bump @convex-dev/workflow 0.3.6 → 0.3.12 (now generic).
• Add @convex-dev/workpool 0.4.6 as an explicit dev dep so the transitive workpool is upgraded; workflow's own workpool.register(t, ...) would otherwise fail typecheck against the older 0.3.1 workpool.
• Cast t only at the rateLimiter.register(...) call site — rate-limiter@0.3.2 is the latest published version and still has the non-generic signature. The cast is annotated as a temporary workaround; an upstream PR genericizes rate-limiter's register, and once a new release lands the cast can be deleted.

Test plan

• npm run typecheck — passes locally (was failing on main for ~6 weeks)
• npm test — all 262 tests pass
• npm run lint — clean

Follow-up

• Upstream PR on get-convex/rate-limiter to genericize register. Once shipped, drop the cast.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/agent@262

commit: 224d882

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR updates the initConvexTest function to explicitly parameterize the convexTest constructor with GenericSchema. The type import is added from convex/server, and the instantiation now passes the generic parameter. Inline comments explain that this schema-type widening aligns the resulting TestConvex instance with the non-generic register signatures of @convex-dev/workflow and @convex-dev/rate-limiter, addressing TestConvex's invariance in its schema type. The runtime registration flow with agent, workflow, and rateLimiter remains unchanged.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly describes the main change: fixing a typecheck failure in a specific file. It is clear, specific, and accurately summarizes the primary fix.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The pull request description comprehensively explains the root cause of the typecheck failure, the dependencies involved, and the specific fix applied, directly relating to all changes in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-ci-typecheck

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ianmacartney]

I think we can drop this if we update convex-test