Skip to content

[Backport 2026.01.xx] #11994: UI Review#12021

Merged
tdipisa merged 2 commits into2026.01.xxfrom
backport-12010-to-2026.01.xx
Mar 11, 2026
Merged

[Backport 2026.01.xx] #11994: UI Review#12021
tdipisa merged 2 commits into2026.01.xxfrom
backport-12010-to-2026.01.xx

Conversation

@offtherailz
Copy link
Copy Markdown
Member

@offtherailz offtherailz commented Feb 25, 2026

Description

Backport of #12010 to 2026.01.xx.

Fixes #11994

@mahmoudadel54 @github-actions
#11994: UI Review (#12010)
9ea6822 
* #11994: UI Review
- fixing UI issue in upload map template
- fix UI issue in camera position for 3D
- fix UI issue in navbar beside the search tool

* - set background of navbar contaier to be white

(cherry picked from commit 2fa4675)
@offtherailz offtherailz added this to the 2026.01.00 milestone Feb 25, 2026
@cla-bot cla-bot Bot added the CLA Ready label Feb 25, 2026
@offtherailz offtherailz mentioned this pull request Feb 25, 2026
Merged
12 tasks
@MV88 MV88 self-requested a review February 25, 2026 18:38
@tdipisa tdipisa linked an issue Feb 26, 2026 that may be closed by this pull request
UI Review #11994
Closed
1 task
tdipisa
tdipisa requested changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are failing checks here @MV88 @mahmoudadel54 (FYI @offtherailz )

@mahmoudadel54
Copy link
Copy Markdown
Contributor

mahmoudadel54 commented Feb 26, 2026 •
edited
Loading

There are failing checks here @MV88 @mahmoudadel54 (FYI @offtherailz )

@tdipisa @offtherailz
There were failures in build and FE.
After re-runing the failed jobs -> build ones succeeded but for FE still failing giving this error

image

@mahmoudadel54 mahmoudadel54 requested review from MV88 and tdipisa March 2, 2026 15:01
@tdipisa tdipisa removed the request for review from MV88 March 2, 2026 17:14
@tdipisa tdipisa assigned tdipisa and unassigned MV88 and mahmoudadel54 Mar 2, 2026
tdipisa
tdipisa requested changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahmoudadel54 please fix conflicts here. Thank you.

@mahmoudadel54 mahmoudadel54 requested review from MV88 and tdipisa March 11, 2026 14:29
tdipisa
tdipisa reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahmoudadel54 is the common.less file here no longer necessary for the backport?

@mahmoudadel54
Copy link
Copy Markdown
Contributor

mahmoudadel54 commented Mar 11, 2026 •
edited
Loading

@mahmoudadel54 is the common.less file here no longer necessary for the backport?

yes it is necessary
it fixes the issue of Medatdata Template UI

tdipisa
tdipisa requested changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahmoudadel54 it is is necessary you have to restore it because it seems you have excluded it from this backport. Why?

@mahmoudadel54
Copy link
Copy Markdown
Contributor

mahmoudadel54 commented Mar 11, 2026 •
edited
Loading

@mahmoudadel54 it is is necessary you have to restore it because it seems you have excluded it from this backport. Why?

it seems merged to 2026.01.xx in this PR before
specifically in this commit: 7c658bb

@tdipisa tdipisa closed this Mar 11, 2026
@tdipisa tdipisa reopened this Mar 11, 2026
@tdipisa tdipisa enabled auto-merge (squash) March 11, 2026 17:35
@tdipisa tdipisa merged commit 5d60017 into 2026.01.xx Mar 11, 2026
23 checks passed
@tdipisa tdipisa deleted the backport-12010-to-2026.01.xx branch March 11, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdipisa tdipisa tdipisa approved these changes

@MV88 MV88 Awaiting requested review from MV88

Assignees

@tdipisa tdipisa

Labels

Backport CLA Ready

Projects

None yet

Milestone

2026.01.00

Development

Successfully merging this pull request may close these issues.

UI Review

4 participants

@offtherailz @mahmoudadel54 @tdipisa @MV88