Skip to content

Groupe open/panoramax streetview support#11822

Merged
offtherailz merged 10 commits intogeosolutions-it:masterfrom
groupe-open-rennes:groupe-open/panoramax-streetview-support
Apr 27, 2026
Merged

Groupe open/panoramax streetview support#11822
offtherailz merged 10 commits intogeosolutions-it:masterfrom
groupe-open-rennes:groupe-open/panoramax-streetview-support

Conversation

@nrc97
Copy link
Copy Markdown
Contributor

@nrc97 nrc97 commented Dec 16, 2025

Description

This PR introduces support for Panoramax as an additional Street View provider in MapStore2. Users can now visualize street‑level imagery using Panoramax alongside existing providers. The feature includes configuration options, i18n strings, attribution handling, and provider selection at runtime.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

Issue

What is the current behavior?
Panoramax is not supportted as streetview provider

What is the new behavior?
We can now use panoramax as provider for the streetview plugin.
Capture d'écran 2025-12-16 122255

Breaking change

  • No

Other useful information

Panoramax OpenAPI Documentation: https://docs.panoramax.fr/api/api/openapi/
Panoramax Viewer Documentation: https://docs.panoramax.fr/web-viewer/#basic-usage

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 16, 2025

@nrc97 thank you so much for contributing with this. We will review as soon as possible.

@nrc97 nrc97 force-pushed the groupe-open/panoramax-streetview-support branch 2 times, most recently from 5eed6a3 to 6e7f4bf Compare December 17, 2025 17:08
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Dec 17, 2025

Hi @nrc97 if you are still working on this, I kindly ask you to convert this PR to a Draft PR to avoid reviewing if you haven't completed yest the development. Thank you so much again for the collaboration and the contribution.

@Gaetanbrl
Copy link
Copy Markdown
Contributor

Is this a tool dedicated to OpenLayers ? (Mapstore offering several map libraries)

@landryb
Copy link
Copy Markdown
Contributor

landryb commented Jan 6, 2026

Fwiw, i'm not in a position to judge the code itself, but from basic testing against a locally deployed panoramax instance and a locally running mapstore from this PR, this works fine, eg sequences are loaded as MVT from the api, and clicking on the sequence brings up a window showing the picture.

Features are basic (eg no link to the complete sequence, which can be useful, nor filters like on panoramax web viewer), but there's always the link to the original picture in panoramax, so that's fine.

if i had a user-level remark to do, when the streetview window has its default scale (eg 'smallish'), the 'back' arrow is a bit hidden by the licence footer for the image. one has to make the window a bit higher to easily interact with the arrow.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 7, 2026

Hi @nrc97 if you are still working on this, I kindly ask you to convert this PR to a Draft PR to avoid reviewing if you haven't completed yest the development. Thank you so much again for the collaboration and the contribution.

@nrc97 can we finally schedule a review session for this? Thank you for confirming that.

@nrc97
Copy link
Copy Markdown
Contributor Author

nrc97 commented Jan 13, 2026

Hi @nrc97 if you are still working on this, I kindly ask you to convert this PR to a Draft PR to avoid reviewing if you haven't completed yest the development. Thank you so much again for the collaboration and the contribution.

@nrc97 can we finally schedule a review session for this? Thank you for confirming that.

@tdipisa Yes, I'll send you my availability by email.

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 13, 2026

@tdipisa Yes, I'll send you my availability by email.

@nrc97 no worries, I was simply asking if we can proceed with a review. I was asking for confirmation that everything is ready for this. No need for a call.

Can you please fix conflicts? Thank you so much for contributing.

Copy link
Copy Markdown
Member

@tdipisa tdipisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrc97 conflicts fix needed.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Jan 21, 2026

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Jan 22, 2026

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

@nrc97 please notice that, thank you.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Jan 28, 2026

In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Feb 24, 2026

@nrc97 please can you sign the CLA as requested to contribute your code?

@tdipisa tdipisa modified the milestones: 2026.01.00, 2026.02.00 Mar 9, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 17:06

This comment was marked as outdated.

@landryb
Copy link
Copy Markdown
Contributor

landryb commented Mar 25, 2026

@nrc97 is there something preventing you from signing the CLA ? to my understanding that's a requirement to properly upstream your code, instead of having to maintain it outside of the mapstore2 repository...

@tdipisa tdipisa self-requested a review March 30, 2026 15:57
@FNI18300
Copy link
Copy Markdown
Contributor

Hello @landryb ,
all CLAs have been signed for OPEN contributors and sent to @tdipisa on Wednesday, March 25, 2026.

This includes me and OPGuillaume, Mbayyari, Fhunkeler and of course Nrc97

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 22, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nakouban Raoul CAMARA.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot Bot removed the CLA Ready label Apr 22, 2026
@nrc97 nrc97 requested a review from offtherailz April 22, 2026 14:42
@nrc97
Copy link
Copy Markdown
Contributor Author

nrc97 commented Apr 22, 2026

Hello @offtherailz

I merged your PR and tested it.
I had to make the following changes:

  • Translation in english of one last remaining french comment
  • The line rule was named "Circle" as the circle rule in the geostyler style for the panoramax layer, I changed it to "Line"

The PR has also been rebased on the master branch and here is a screenshot of the test I made
image

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Apr 23, 2026

@nrc97 I'm sorry but it seems there is some issue with the CLA recognition which is no longer passing the automated check. It was set to Nrc97 account, and the check was passing successfully, while now I see it is nrc97. Since you already have signed the CLA form, I've updated the .clabot file accordingly. To pass this check you need to align your PR to the latest master, please.

@nrc97
Copy link
Copy Markdown
Contributor Author

nrc97 commented Apr 23, 2026

@nrc97 I'm sorry but it seems there is some issue with the CLA recognition which is no longer passing the automated check. It was set to Nrc97 account, and the check was passing successfully, while now I see it is nrc97. Since you already have signed the CLA form, I've updated the .clabot file accordingly. To pass this check you need to align your PR to the latest master, please.

Thank you @tdipisa
It was a mistake, it should be nrc97

@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Apr 23, 2026

@nrc97 I'm sorry but it seems there is some issue with the CLA recognition which is no longer passing the automated check. It was set to Nrc97 account, and the check was passing successfully, while now I see it is nrc97. Since you already have signed the CLA form, I've updated the .clabot file accordingly. To pass this check you need to align your PR to the latest master, please.

Thank you @tdipisa It was a mistake, it should be nrc97

ok @nrc97 thank you for clarifying that. Anyway you have to align the branch you have used for this PR. Many thanks.

nrc97 and others added 8 commits April 23, 2026 14:16
map.forEachFeatureAtPixel in openlayers/Map.jsx adapted for detection of features of type RenderFeature used for MVT layers. By doing that, MVT layers are clickable and the intersected features are return on clic
TileProviderLayer for being able to create MVT layer and display it.
- Create a viewer using pnx-photo-viewer to display pictures.
- Add a Panoramax VectorTileLayer using OpenLayers styling to match other providers.
- Handle click events: retrieve picture data directly from the layer datas, or call the API if the data is not found.
Removed unused DEFAULT_SRS constant from panoramax.js to match the eslint configuration
@nrc97 nrc97 force-pushed the groupe-open/panoramax-streetview-support branch from 63ecef7 to f8078d3 Compare April 23, 2026 12:22
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 23, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nakouban Raoul CAMARA.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@nrc97 nrc97 force-pushed the groupe-open/panoramax-streetview-support branch from f8078d3 to 816472b Compare April 23, 2026 12:35
@cla-bot cla-bot Bot added the CLA Ready label Apr 23, 2026
@tdipisa
Copy link
Copy Markdown
Member

tdipisa commented Apr 24, 2026

@nrc97 All good now regarding the CLA. I just realized there is no issue associated to this PR. It should be, please. See also the contributing rules here. Can you create it please and include the link in the PR description? Thanks in advance for this last step.

@offtherailz offtherailz linked an issue Apr 27, 2026 that may be closed by this pull request
4 tasks
@offtherailz offtherailz removed the request for review from tdipisa April 27, 2026 12:41
@offtherailz
Copy link
Copy Markdown
Member

I created the #12312 issue for this, in order to move on and finalize this task.

@offtherailz offtherailz enabled auto-merge (squash) April 27, 2026 12:42
@offtherailz offtherailz requested a review from tdipisa April 27, 2026 12:43
@offtherailz offtherailz merged commit 1719c54 into geosolutions-it:master Apr 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Panoramax as Street View provider

9 participants