Groupe open/panoramax streetview support#11822
Groupe open/panoramax streetview support#11822offtherailz merged 10 commits intogeosolutions-it:masterfrom
Conversation
|
@nrc97 thank you so much for contributing with this. We will review as soon as possible. |
5eed6a3 to
6e7f4bf
Compare
|
Hi @nrc97 if you are still working on this, I kindly ask you to convert this PR to a Draft PR to avoid reviewing if you haven't completed yest the development. Thank you so much again for the collaboration and the contribution. |
|
Is this a tool dedicated to OpenLayers ? (Mapstore offering several map libraries) |
|
Fwiw, i'm not in a position to judge the code itself, but from basic testing against a locally deployed panoramax instance and a locally running mapstore from this PR, this works fine, eg sequences are loaded as MVT from the api, and clicking on the sequence brings up a window showing the picture. Features are basic (eg no link to the complete sequence, which can be useful, nor filters like on panoramax web viewer), but there's always the link to the original picture in panoramax, so that's fine. if i had a user-level remark to do, when the streetview window has its default scale (eg 'smallish'), the 'back' arrow is a bit hidden by the licence footer for the image. one has to make the window a bit higher to easily interact with the arrow. |
@nrc97 can we finally schedule a review session for this? Thank you for confirming that. |
@tdipisa Yes, I'll send you my availability by email. |
|
In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code |
@nrc97 please notice that, thank you. |
|
In order to contribute to the MapStore project, the CLA (Contributor License agreement) should be sent signed to GeoSolutions. Please consult contributing rules at: https://github.com/geosolutions-it/MapStore2/wiki/Contributing-to-MapStore#contributing-code |
|
@nrc97 please can you sign the CLA as requested to contribute your code? |
|
@nrc97 is there something preventing you from signing the CLA ? to my understanding that's a requirement to properly upstream your code, instead of having to maintain it outside of the mapstore2 repository... |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nakouban Raoul CAMARA.
|
|
Hello @offtherailz I merged your PR and tested it.
The PR has also been rebased on the master branch and here is a screenshot of the test I made |
|
@nrc97 I'm sorry but it seems there is some issue with the CLA recognition which is no longer passing the automated check. It was set to Nrc97 account, and the check was passing successfully, while now I see it is nrc97. Since you already have signed the CLA form, I've updated the .clabot file accordingly. To pass this check you need to align your PR to the latest master, please. |
Thank you @tdipisa |
ok @nrc97 thank you for clarifying that. Anyway you have to align the branch you have used for this PR. Many thanks. |
map.forEachFeatureAtPixel in openlayers/Map.jsx adapted for detection of features of type RenderFeature used for MVT layers. By doing that, MVT layers are clickable and the intersected features are return on clic TileProviderLayer for being able to create MVT layer and display it.
- Create a viewer using pnx-photo-viewer to display pictures. - Add a Panoramax VectorTileLayer using OpenLayers styling to match other providers. - Handle click events: retrieve picture data directly from the layer datas, or call the API if the data is not found.
…h, Italian and German
Removed unused DEFAULT_SRS constant from panoramax.js to match the eslint configuration
63ecef7 to
f8078d3
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nakouban Raoul CAMARA.
|
…ure in startpoint/endpoint geom function
f8078d3 to
816472b
Compare
|
I created the #12312 issue for this, in order to move on and finalize this task. |

Description
This PR introduces support for Panoramax as an additional Street View provider in MapStore2. Users can now visualize street‑level imagery using Panoramax alongside existing providers. The feature includes configuration options, i18n strings, attribution handling, and provider selection at runtime.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Panoramax is not supportted as streetview provider
What is the new behavior?

We can now use panoramax as provider for the streetview plugin.
Breaking change
Other useful information
Panoramax OpenAPI Documentation: https://docs.panoramax.fr/api/api/openapi/
Panoramax Viewer Documentation: https://docs.panoramax.fr/web-viewer/#basic-usage