Open
Conversation
…-based-queries-rebase
…-based-queries-rebase
…ine into new-pixel-based-queries-rebase
…ks now that resolutions are no longer part of the query rectangle (#1112) - [ ] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users. --- Here is a brief summary of what I did: <TEXT>
…and raster:bands for stac items
michaelmattig
force-pushed
the
stac-import
branch
from
f989d44 to
22372bf
Compare
michaelmattig
force-pushed
the
stac-import
branch
from
22372bf to
bb0b4d1
Compare
ChristianBeilschmidt
requested changes
Mar 20, 2026
Member
ChristianBeilschmidt
left a comment
ChristianBeilschmidt
left a comment
There was a problem hiding this comment.
Wie teste ich das am besten?
| tile.band = output_band; | ||
| Some(Ok(tile)) | ||
| } else { | ||
| warn!("BandFilter: Received tile for band {} which is not in the selected bands, skipping. This is a bug.", tile.band); |
|
|
||
| /// A raster data type. | ||
| #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize, ToSchema)] | ||
| #[serde(rename_all = "camelCase")] |
| } | ||
| } | ||
|
|
||
| #[api_operator( |
| } | ||
| } | ||
|
|
||
| #[api_operator( |
| } | ||
| } | ||
|
|
||
| #[api_operator( |
| } | ||
| } | ||
|
|
||
| #[api_operator( |
| } | ||
| } | ||
|
|
||
| #[api_operator( |
Comment on lines
109
to
+157
| @@ -102,6 +152,9 @@ impl TryFrom<VectorOperator> for Box<dyn OperatorsVectorOperator> { | |||
| VectorOperator::RasterVectorJoin(rvj) => { | |||
| OperatorsRasterVectorJoin::try_from(rvj).map(OperatorsVectorOperator::boxed) | |||
| } | |||
| VectorOperator::Reprojection(reprojection) => { | |||
| OperatorsReprojection::try_from(reprojection).map(OperatorsVectorOperator::boxed) | |||
| } | |||
Member
There was a problem hiding this comment.
Mega, kann man hier evtl. eine Checklist einfügen, was noch fehlt? Du hast ja gefühlt 60% gecovered.
Comment on lines
+5362
to
+5468
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "max" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "first" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "last" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "mean" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "sum" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "ignoreNoData", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "ignoreNoData": { | ||
| "type": "boolean" | ||
| }, | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "count" | ||
| ] | ||
| } | ||
| } | ||
| }, |
Member
There was a problem hiding this comment.
Looks rather odd with different type and enum exactly one string, doesn't it?
Comment on lines
+7684
to
+7711
| "enum": [ | ||
| "resolution" | ||
| ] | ||
| }, | ||
| "x": { | ||
| "type": "number", | ||
| "format": "double" | ||
| }, | ||
| "y": { | ||
| "type": "number", | ||
| "format": "double" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "type": "object", | ||
| "required": [ | ||
| "x", | ||
| "y", | ||
| "type" | ||
| ], | ||
| "properties": { | ||
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "fraction" | ||
| ] | ||
| }, |
Member
There was a problem hiding this comment.
hier irgendwie auch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to users.Here is a brief summary of what I did: